Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326895 - Extend commons notification framework to support builds notifications
Summary: Extend commons notification framework to support builds notifications
Status: RESOLVED INVALID
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-04 04:28 EDT by Torkild Resheim CLA
Modified: 2011-01-31 14:43 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torkild Resheim CLA 2010-10-04 04:28:32 EDT 
The commons notification framework should be extended to support builds notifications instead of having a semi-duplicated implementation.
See bug 325079 comment #16.
Comment 1 Torkild Resheim CLA 2010-10-04 04:55:23 EDT 
In order to make the BuildsView a notification sink I will have to change this extension point a bit. Sinks should implement a new INotificationSink instead extending NotificationSink.
Comment 2 Torkild Resheim CLA 2010-10-04 04:56:38 EDT 
(In reply to comment #1)
> In order to make the BuildsView a notification sink I will have to change this
> extension point a bit. Sinks should implement a new INotificationSink instead
> extending NotificationSink.
As a side note. I also think it makes much more sense as NotificationSink does not provide any features.
Comment 3 Torkild Resheim CLA 2010-10-04 08:27:17 EDT 
Well, it appears that we don't really have to do any changes.
Comment 4 Steffen Pingel CLA 2010-10-04 17:49:22 EDT 
The reason for using an abstract class is that it allows us to add methods in the future without having to create INoitifcationSink2 ..3 etc.