326878 – [tests] Registers JUnit test fail with GDB 7.2

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326878 - [tests] Registers JUnit test fail with GDB 7.2

Summary: [tests] Registers JUnit test fail with GDB 7.2

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-dsf-gdb (show other bugs)
Version:	8.0
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Marc Khouzam
QA Contact:	Marc Khouzam

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-10-03 23:54 EDT by Marc Khouzam
Modified:	2011-01-28 15:17 EST (History)
CC List:	3 users (show)

See Also:

Flags:	john.cortell: review+

Attachments
Fix (5.19 KB, patch) 2011-01-22 21:57 EST, Marc Khouzam	marc.khouzam: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Khouzam

2010-10-03 23:54:03 EDT

The Registers JUnit tests fail when using GDB 7.2.  This is because the new GDB lists more registers than the previous version.

Comment 1 Marc Khouzam

2011-01-22 21:57:31 EST

Created attachment 187375 [details]
Fix

Fixed by updating the list of registers to match what gdb returns in version 7.2

Comment 2 Marc Khouzam

2011-01-22 22:00:41 EST

Committed to HEAD.

John, can you check if the JUnits test now work with GDB 7.2 on Windows. 
(No hurry)

I think you can get MinGW GDB 7.2 at http://sourceforge.net/projects/mingw/files/MinGW/BaseSystem/GDB/

The entire Suite_7_2 should pass except two tests in Expressions which we don't have a fix for yet.

Thanks

Comment 3 CDT Genie

2011-01-22 22:23:02 EST

*** cdt cvs genie on behalf of mkhouzam ***
Bug 326878: Registers JUnit test fail with GDB 7.2

[*] MIRegistersTest.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/MIRegistersTest.java?root=Tools_Project&r1=1.8&r2=1.9

[*] MIRegistersTest_7_2.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/tests/tests_7_2/MIRegistersTest_7_2.java?root=Tools_Project&r1=1.1&r2=1.2

Comment 4 Marc-André Laperle

2011-01-23 00:45:37 EST

(In reply to comment #2)
> The entire Suite_7_2 should pass except two tests in Expressions which we don't
> have a fix for yet.

I ran it multiple times and it passes except the two tests but once I got an error in MIMemoryTest.asynchronousReadWrite but I can't reproduce it right now.

Comment 5 Marc Khouzam

2011-01-24 11:55:21 EST

(In reply to comment #4)
> (In reply to comment #2)
> > The entire Suite_7_2 should pass except two tests in Expressions which we don't
> > have a fix for yet.
> 
> I ran it multiple times and it passes except the two tests but once I got an
> error in MIMemoryTest.asynchronousReadWrite but I can't reproduce it right now.

Thanks M-A!  I would like to encourage this behavior.  If you can run tests or verify fixes, although I can't put you as an official reviewer, your help is very valuable.

Comment 6 Marc-André Laperle

2011-01-24 17:43:00 EST

(In reply to comment #5)
> Thanks M-A!  I would like to encourage this behavior.  If you can run tests or
> verify fixes, although I can't put you as an official reviewer, your help is
> very valuable.

Sure! Feel free to CC me. BTW, it looks like python is supported now in MinGW's gdb, I see gdb-python27.exe! I'll give that a try.

Comment 7 John Cortell

2011-01-28 15:17:59 EST

Looks good.