Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326818 - [validation] Text after HTML style comment in JavaScript region marked as validation error
Summary: [validation] Text after HTML style comment in JavaScript region marked as val...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2 P   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
: 326420 (view as bug list)
Depends on: 326422
Blocks:
  Show dependency tree
 
Reported: 2010-10-01 17:00 EDT by Chris Jaun CLA
Modified: 2010-10-09 08:29 EDT (History)
3 users (show)

See Also:
thatnitind: review+

Attachments
patch (23.25 KB, patch)
2010-10-01 17:07 EDT, Chris Jaun CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jaun CLA 2010-10-01 17:00:51 EDT 
+++ This bug was initially created as a clone of Bug #326422 +++

Fix for this bug is also needed in 3.2.3 and 3.3

+++ This bug was initially created as a clone of Bug #326303 +++

Currently the JSDT validator does not support text after a leading opening HTML style comment in a JavaScript region.  This scenario is stated as valid in http://www.w3.org/TR/REC-html40/interact/scripts.html#h-18.3

Example:

<script type="text/javascript">
<!--  to hide script contents from old browsers
var v = "foo";
// -->
</script>
Comment 1 Chris Jaun CLA 2010-10-01 17:07:11 EDT 
Created attachment 180092 [details]
patch
Comment 2 Ian Tewksbury CLA 2010-10-05 08:17:40 EDT 
*** Bug 326420 has been marked as a duplicate of this bug. ***
Comment 3 Carl Anderson CLA 2010-10-09 08:29:51 EDT 
Committed to R3_2_2_patches