Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326809 - Hitting a breakpoint during a step causes debug buttons to disable
Summary: Hitting a breakpoint during a step causes debug buttons to disable
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M3   Edit
Assignee: Michael Rennie CLA
QA Contact: Simon Kaegi CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 327270 327278
  Show dependency tree
 
Reported: 2010-10-01 14:09 EDT by Michael Rennie CLA
Modified: 2010-10-07 16:13 EDT (History)
1 user (show)

See Also:


Attachments
fix (1.20 KB, patch)
2010-10-01 14:24 EDT, Michael Rennie CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2010-10-01 14:09:10 EDT
code from HEAD

debug the following snippet:

function Func(fval){
    this.__defineSetter__("value", function(val){
        value = val;  //bp here
    });
}

var myfunc = new Func("foo"); //bp here
myfunc.value = "foo2";

and step over until you hit the breakpoint in __defineSetter__. Notice that all of the debugging buttons (step over / into / out) are all disabled.

Taking a quick look revealed that we still think we are stepping in this case, so when the commands poll for enablement (canStep) we say no.

We should be handling the case of hitting a breakpoint while stepping - we already handle resuming while stepping.
Comment 1 Michael Rennie CLA 2010-10-01 14:24:02 EDT
Created attachment 180077 [details]
fix

patch also has an update to not make multiple calls to JavaScriptThread.resumeUnderlyingThread() as well as avoid sending a RESUME DebugEvent when not asked for.
Comment 2 Michael Rennie CLA 2010-10-01 14:58:06 EDT
applied patch to HEAD