Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326753 - Java heap space when discovering JSP containing special characters
Summary: Java heap space when discovering JSP containing special characters
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P1 blocker (vote)
Target Milestone: 0.9.0 M3   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 326527
Blocks:
  Show dependency tree
 
Reported: 2010-10-01 05:38 EDT by Frederic Madiot CLA
Modified: 2011-01-11 04:59 EST (History)
4 users (show)

See Also:
fabien.giquel: indigo+

Attachments
JSP without sepcial characters (869 bytes, application/octet-stream)
2010-10-01 05:39 EDT, Frederic Madiot CLA 		no flags Details
JSP with special characters (876 bytes, application/octet-stream)
2010-10-01 05:40 EDT, Frederic Madiot CLA 		no flags Details
Patch for the MoDiscoJSP Grammar (41 bytes, patch)
2010-10-14 04:52 EDT, Nicolas Guyomar CLA 		no flags Details | Diff
Patch of MoDisco JSP Grammar for heap space issue (577 bytes, patch)
2010-10-21 05:27 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Madiot CLA 2010-10-01 05:38:45 EDT 
I have a Java heap space error when I launch the JSP discoverer on a JSP containing special characters.

Plugin Version : org.eclipse.modisco.jee.jsp.discoverer_0.9.0.v201009291601

Here are two version of the same JSP:
test1.jsp contains special characters -> Java heap space
test2.jsp replaced special characters -> Model created
Comment 1 Frederic Madiot CLA 2010-10-01 05:39:30 EDT 
Created attachment 180030 [details]
JSP without sepcial characters
Comment 2 Frederic Madiot CLA 2010-10-01 05:40:23 EDT 
Created attachment 180031 [details]
JSP with special characters
Comment 3 Fabien Giquel CLA 2010-10-01 05:50:18 EDT 
Such an error should be fixed in bug 326527 with an exception manager in further version of MoDisco.

Nicolas Guyomar.
Comment 4 Nicolas Guyomar CLA 2010-10-14 04:52:47 EDT 
Created attachment 180857 [details]
Patch for the MoDiscoJSP Grammar

Hi, 

The problem as been fixed for every characters contained in ISO_8859 
see: http://fr.wikipedia.org/wiki/ISO_8859

A infinite loop on this problem has also been fixed.

Tests are OK

(a) I, Nicolas Guyomar, wrote 100% of the code of the contribution
(b) I have the right to contribute the code to Eclipse
(c) I want to contribute this code under EPL


Regards

Nicolas Guyomar
Comment 5 Fabien Giquel CLA 2010-10-18 11:37:10 EDT 
Hi Nicolas,
there is a problem with your patch content (not a patch at all).

thanks in advance.
Comment 6 Nicolas Guyomar CLA 2010-10-21 05:27:00 EDT 
Created attachment 181373 [details]
Patch of MoDisco JSP Grammar for heap space issue

Hi Fabien,

This is the right patch

Regards
Nicolas Guyomar
Comment 7 Fabien Giquel CLA 2010-10-25 05:03:41 EDT 
The fix has been commited into SVN.
Comment 8 Fabien Giquel CLA 2010-10-25 05:06:20 EDT 
Commited in revision 3322.
Comment 9 Hugo Bruneliere CLA 2011-01-11 04:59:30 EST 
Bug fixed via a patch.