Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326731 - Exception when undoing a domain model update done through EMF.Edit
Summary: Exception when undoing a domain model update done through EMF.Edit
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 0.7.0   Edit
Assignee: Christian Brand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-01 00:05 EDT by Romain Raugi CLA
Modified: 2010-10-07 05:07 EDT (History)
3 users (show)

See Also:

Attachments
The tutorial modified to add a property section using EMF.Edit property sources (50.50 KB, application/x-zip-compressed)
2010-10-01 00:06 EDT, Romain Raugi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Raugi CLA 2010-10-01 00:05:14 EDT 
Build Identifier: 20100617-1415

A regression from 0.7.0RC1 at the GFCommandStack level. The IExecutionInfo stack management prevent EMF Edit PropertySources from modifying the model. The editor's undo stack is not consistent anymore.

Reproducible: Always

Steps to Reproduce:
1. Download the modified attached tutorial, it includes a property section using EMF Edit.
2. Run an Eclipse with this modified example.
3. Create an EClass.
4. Rename it though the property sheet.
5. Undo, the figure should be updated
6. Undo => exception

java.util.EmptyStackException
at java.util.Stack.peek(Unknown Source)
at java.util.Stack.pop(Unknown Source)
at org.eclipse.graphiti.ui.internal.editor.GFCommandStack.undo(GFCommandStack.java:217)
at org.eclipse.gef.ui.actions.UndoAction.run(UndoAction.java:94)
Comment 1 Romain Raugi CLA 2010-10-01 00:06:15 EDT 
Created attachment 180008 [details]
The tutorial modified to add a property section using EMF.Edit property sources
Comment 2 Michael Wenz CLA 2010-10-01 03:58:20 EDT 
Regression came in with non-EMF undo evaluations
Comment 3 Christian Brand CLA 2010-10-01 04:07:52 EDT 
Problem should be solved.
The evaluative solution for undo support of non-EMF models has been removed. (Solution is not that easy. ;-( )
Comment 4 Michael Wenz CLA 2010-10-07 05:07:06 EDT 
Part of 0.7.0 release