Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326729 - support line-based commenting
Summary: support line-based commenting
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 321270 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-30 23:14 EDT by Steffen Pingel CLA
Modified: 2011-01-06 13:28 EST (History)
5 users (show)

See Also:

Attachments
Contribution based on Atlassian Connector for Eclipse (217.00 KB, application/octet-stream)
2010-09-30 23:15 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2010-09-30 23:14:30 EDT 
To facilitate code reviews and to support functionality offered by web-based system such as Gerrit or Crucible the Reviews framework should support line-based commenting:

* Markers that show which lines have comments.
* A ruler that marks commented lines and shows comments in a hover.
* Menu contributions, dialogs and hovers for entering comments.
Comment 1 Steffen Pingel CLA 2010-09-30 23:15:43 EDT 
Created attachment 180006 [details]
Contribution based on Atlassian Connector for Eclipse
Comment 2 Steffen Pingel CLA 2010-09-30 23:27:29 EDT 
The EPL based Atlassian Connector for Eclipse offers this functionality. The attached contribution is based on Revision 107574 of the com.atlassian.connector.eclipse.crucible.ui plug-in. The following changes were applied:

* Required support classes from com.atlassian.connector.eclipse.crucible.core and com.atlassian.connector.eclipse.commons.ui were added.
* Crucible specific classes and code was removed.
* Code that introduced dependencies on 3rd party plug-ins was removed.

The original sources and project can be found at https://studio.atlassian.com/browse/PLE .
Comment 3 Steffen Pingel CLA 2010-10-20 14:57:10 EDT 
*** Bug 321270 has been marked as a duplicate of this bug. ***
Comment 4 Steffen Pingel CLA 2010-11-09 13:32:20 EST 
The following people were involved in authoring the contribution: Pawe? Niewiadomski, Wojciech Seliga, Jacek Jaroczynski, Steffen Pingel, Thomas Ehrnhoefer, Shawn Minto.
Comment 5 Steffen Pingel CLA 2010-11-09 13:33:05 EST 
This is my confirmation that I, Steffen Pingel:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 6 Thomas Ehrnhoefer CLA 2010-11-09 13:35:45 EST 
This is my confirmation that I, Thomas Ehrnhoefer:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 7 Shawn Minto CLA 2010-11-09 13:36:10 EST 
This is my confirmation that I, Shawn Minto:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 8 Wojciech Seliga CLA 2010-11-19 10:27:56 EST 
This is my confirmation that I, Wojciech Seliga:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 9 Pawel Niewiadomski CLA 2010-11-19 10:28:21 EST 
This is my confirmation that I, Pawel Niewiadomski:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 10 Jacek Jaroczynski CLA 2010-11-29 07:06:53 EST 
This is my confirmation that I, Jacek Jaroczynski:
Authored the code.
Have a right to contribute the content to Eclipse.
Contribute the content under EPL.
Comment 11 Steffen Pingel CLA 2010-12-06 11:06:21 EST 
The CQ has been approved and the code has been checked into Git. We'll open new bugs to track refactorings of the contribution to integrate it with the existing code. Thanks everyone for moving this along!