326716 – NPE in EDC's DsfTerminateCommand handling

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326716 - NPE in EDC's DsfTerminateCommand handling

Summary: NPE in EDC's DsfTerminateCommand handling

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-edc (show other bugs)
Version:	8.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Ken Ryall
QA Contact:	Ken Ryall

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-30 17:00 EDT by John Cortell
Modified:	2010-10-01 08:19 EDT (History)
CC List:	0 users

See Also:

Flags:	ken.ryall: review+

Attachments
fix (5.73 KB, patch) 2010-09-30 17:01 EDT, John Cortell	john.cortell: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Cortell

2010-09-30 17:00:31 EDT

There's a couple of issues.

1. DsfTerminateCommand.canExecute() assumes that IProcesses.canTerminate() is successful and returns a data object (a Boolean). It should assume neither. This is where the NPE happens (due to # 2)

2. Boolean properties in the EDC Run Control context should have implicit default values. Returning a null Boolean object to a requester doesn't make a lot of sense to me.

Comment 1 John Cortell

2010-09-30 17:01:59 EDT

Created attachment 180001 [details]
fix

Comment 2 John Cortell

2010-09-30 17:03:03 EDT

Committed to HEAD. Ken, please review.

Comment 3 CDT Genie

2010-09-30 17:23:02 EDT

*** cdt cvs genie on behalf of jcortell ***
Bug 326716: NPE in EDC's DsfTerminateCommand handling

[*] RunControl.java 1.38 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/internal/services/dsf/RunControl.java?root=Tools_Project&r1=1.37&r2=1.38

[*] DsfTerminateCommand.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.ui/src/org/eclipse/cdt/debug/edc/internal/ui/DsfTerminateCommand.java?root=Tools_Project&r1=1.3&r2=1.4

Comment 4 Ken Ryall

2010-10-01 08:19:58 EDT

+1 Nice cleanup.