Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326691 - Add new JAXB components to WTP build
Summary: Add new JAXB components to WTP build
Status: VERIFIED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JAXB (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.0 M3   Edit
Assignee: Tran Le CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-30 12:13 EDT by Tran Le CLA
Modified: 2011-01-18 15:33 EST (History)
3 users (show)

See Also:


Attachments
proposed patch (8.35 KB, patch)
2010-10-05 12:35 EDT, Tran Le CLA
no flags Details | Diff
Proposed patch p2 Directory (1.03 KB, patch)
2010-10-06 12:54 EDT, Tran Le CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tran Le CLA 2010-09-30 12:13:58 EDT
Create components and features to include JAXB into Web Tools build.
Comment 1 Tran Le CLA 2010-10-05 00:22:07 EDT
David,
Our new JAXB plugins are missing from the wtp-sdk-I-3.3.0-20101004154323.zip from today's build. 
However they were present in October 1st build I-3.3.0-20101001042928.

I have been investigating our features definition but could not found anything abnormal. So I had the idea to look into the dali-sdk-buildrepo-I-3.3.0-20101004154323.zip and found them there.

I will continue to investigate but I was wondering if you had saw problems similar to this in the past.
Thanks.
Comment 2 David Williams CLA 2010-10-05 01:51:35 EDT
The way things are now, there's a couple of places that have to be updated to have features included in various places. Only buildrepo's are completely automatic based on feature definition. (I'm working on figuring out how to improve that, without losing some things ... but in the mean time, I can add it. 

What's its name/id?
Comment 3 David Williams CLA 2010-10-05 02:56:08 EDT
FYI, I think the way this will end up is that the category.xml files in your component will need to be updated when you add a feature you want in repositories and zip files. The "categories" there must stay the same, but you'd add a feature and associate it to one of the categories (minimum executable, sdk (and you should have one one each for any "new" thing added) or tests category if you have a new test feature ... and, it'd be best if we had one test feature for each main feature ... but, I know we are a few short at the moment. 

Just thought I'd mention these things if you want to study up, comment, etc. 
But, again, I can "manually" add it to the current 3 or 4 places where the IU lists are currently hard coded. 

I expect a lot of progress in next few days ... so it'll be kind of fluid till then.
Comment 4 Tran Le CLA 2010-10-05 12:35:09 EDT
Created attachment 180258 [details]
proposed patch

David,
I made an attempt to modify the "category" files in build code.
Please review, thanks.
Comment 5 David Williams CLA 2010-10-05 12:55:17 EDT
(In reply to comment #4)
> Created an attachment (id=180258) [details]
> proposed patch
> 
> David,
> I made an attempt to modify the "category" files in build code.
> Please review, thanks.

Looked right to me. I applied and restarted an I-build. 
FYI, the only ones that currently matter are only in the dali-sdk and dali-tests components. But I applied all just as place holding reminders. 

This might "mess up" M-builds until I adjust ... this is just first case there features/categories differ by stream ... so we'll invent something to handle that ... probably need to move them to releng project (next to maps) since that's where stream sensitive data lives. So, expect more changes over next few days :) 

thanks
Comment 6 David Williams CLA 2010-10-05 21:10:54 EDT
must be in. Since I see a layout error is detected :) 

Missing pattern or file: about.html in file: org.eclipse.jpt.jaxb.core_1.0.0.v201009300002.jar
Comment 7 Tran Le CLA 2010-10-05 22:50:15 EDT
(In reply to comment #6)
> must be in. Since I see a layout error is detected :) 
> 
> Missing pattern or file: about.html in file:
> org.eclipse.jpt.jaxb.core_1.0.0.v201009300002.jar

Thanks David, it is in, and I have fixed the layout error.
Comment 8 David Williams CLA 2010-10-06 04:04:11 EDT
Hmm, maybe there's more. I see in latest 3.3 I build, there tests were not installed, with the p2 Directory log saying it could not find 

org.eclipse.jpt_sdk.feature.feature.group (which, of course, means org.eclipse.jpt_sdk.feature). 

I haven't checked logs or anything ... but appears this feature was not built? 

Let me know if you want me to look at in depth ... but, I'll let you check first, in case its a simple typo, or something. 

Thanks,
Comment 9 David Williams CLA 2010-10-06 04:09:15 EDT
Tell me again ... which of these 3 sdk features do you use? I know you've told me before, and I'm sure I could track it down, but assuming you know right off the top of your head. 

Thanks, 

org.eclipse.jpt_sdk.assembly.feature
org.eclipse.jpt_sdk.feature
org.eclipse.jpt.sdk
Comment 10 Tran Le CLA 2010-10-06 12:54:00 EDT
Created attachment 180350 [details]
Proposed patch p2 Directory
Comment 11 Tran Le CLA 2010-10-06 12:55:24 EDT
(In reply to comment #8)
> Hmm, maybe there's more. I see in latest 3.3 I build, there tests were not
> installed, with the p2 Directory log saying it could not find 
> 
> org.eclipse.jpt_sdk.feature.feature.group (which, of course, means
> org.eclipse.jpt_sdk.feature). 
> 
> I haven't checked logs or anything ... but appears this feature was not built? 
> 
> Let me know if you want me to look at in depth ... but, I'll let you check
> first, in case its a simple typo, or something. 
> 
> Thanks,

I guess it’s a typo, I have attached a patch.
Thanks.
Comment 12 Tran Le CLA 2010-10-06 13:01:31 EDT
(In reply to comment #9)
> Tell me again ... which of these 3 sdk features do you use? I know you've told
> me before, and I'm sure I could track it down, but assuming you know right off
> the top of your head. 
> 
> Thanks, 
> 
> org.eclipse.jpt_sdk.assembly.feature
> org.eclipse.jpt_sdk.feature
> org.eclipse.jpt.sdk

We are using org.eclipse.jpt_sdk.feature
Comment 13 Neil Hauge CLA 2010-10-21 12:01:54 EDT
I think all of the currently planned work here has been successfully completed.  Please reopen if this is not the case.
Comment 14 Jolene Moffitt CLA 2011-01-18 15:33:06 EST
Verified in Build I-3.3.0-20101104191817

Verified the following .jar files exist in the eclipse>plugins directory - org.eclipse.jpt.jaxb.core.schmeagen.source_(build).jar, org.eclipse.jpt.jaxb.core.schemagan_(build).jar, org.eclipse.jpt.jaxb.core.source_(build).jar, org.eclipse.jpt.jsxb.core_(build).jar  Verified the following files exist in the eclipse>features directory - org.eclipse.jpt.jaxb.feature.source_(build), org.eclipse.jpt.jaxb.eclipselink_sdk.feature_(build), org.eclipse.jpt.jaxb.feature_(build), org.eclipse.jpt.jaxb_sdk.feature_(build), org.eclipse.jpt.jaxb_eclipselink.feature(build), org.eclipse.jpt.jaxb.eclipselink.feature.source(build). See the link to view test steps for verification. 
http://wiki.eclipse.org/Dali_3.0_M3