Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326654 - [outline] The Outline view menu ordering is wrong
Summary: [outline] The Outline view menu ordering is wrong
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Anton Leherbauer CLA
QA Contact: Anton Leherbauer CLA
URL:
Whiteboard:
Keywords:
Depends on: 326748
Blocks:
  Show dependency tree
 
Reported: 2010-09-30 06:25 EDT by Anton Leherbauer CLA
Modified: 2010-10-15 03:23 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Leherbauer CLA 2010-09-30 06:25:11 EDT
The "Group *" menu items are no longer grouped together.
Comment 1 Anton Leherbauer CLA 2010-10-01 04:47:35 EDT
It appears that SubMenuManager.appendToGroup() behaves unexpectedly in the Outline view context.  The reason is that all contributions of all outline view pages are collected in one list of the parent contribution manager and each SubMenuManager just tracks which items it has added.  I.e. the list can contain duplicate separator items from different SubMenuManagers.  appendToGroup() does not consider the contributing SubMenuManager when searching for the separator so that the first matching separator from any SubMenuManager is used to insert the new item.

That's why the order is only correct for the first editor.
Comment 2 Anton Leherbauer CLA 2010-10-15 02:40:07 EDT
I committed a workaround to HEAD and cdt_7_0.