Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326594 - [Backport] Lost preference: build only if changes in workspace
Summary: [Backport] Lost preference: build only if changes in workspace
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-build (show other bugs)
Version: 7.0.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0.2   Edit
Assignee: Vivian Kong CLA
QA Contact: Andrew Gvozdev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 16:24 EDT by Vivian Kong CLA
Modified: 2011-05-13 10:55 EDT (History)
1 user (show)

See Also:

Attachments
proposed patch (4.38 KB, patch)
2010-09-29 16:24 EDT, Vivian Kong CLA 		no flags Details | Diff
updated patch (2.42 KB, patch)
2010-09-30 10:43 EDT, Vivian Kong CLA 		cdtdoug: iplog-
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivian Kong CLA 2010-09-29 16:24:11 EDT 
Created attachment 179893 [details]
proposed patch

This is a backport of bug 321778.

The patch for cdt_7_0 is slightly different since we cannot add/change APIs in CDT 7.0.x.  Keith, please take a look and let me know if that works for you.
Comment 1 Keith W. Campbell CLA 2010-09-30 10:32:10 EDT 
Vivian, I don't understand why changes to ACBuilder are included
in the patch: it appears only that private string constants are
inlined.

Other than that, though, the patch looks good to me.
Comment 2 Vivian Kong CLA 2010-09-30 10:43:49 EDT 
Created attachment 179963 [details]
updated patch

(In reply to comment #1)
> Vivian, I don't understand why changes to ACBuilder are included
> in the patch: it appears only that private string constants are
> inlined.
> 
> Other than that, though, the patch looks good to me.

That's because I did a search-and-replace on the patch you attached on bug 321778.  =)  Here's an updated patch.
Comment 3 Keith W. Campbell CLA 2010-09-30 11:01:23 EDT 
I think your first patch would have been fine, but the new one is better.
Comment 4 Vivian Kong CLA 2010-09-30 11:24:34 EDT 
Since we would like to create a patch for this for CDT 7.0.1.  I have created a new branch cdt_7_0_1.

Fixed in cdt_7_0 and cdt_7_0_1.