Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326584 - Comments found in javamodel but not in kdmmodel
Summary: Comments found in javamodel but not in kdmmodel
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Linux
: P1 normal (vote)
Target Milestone: 0.9.0 M3   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 15:06 EDT by Björn Tietjens CLA
Modified: 2010-10-05 05:16 EDT (History)
5 users (show)

See Also:
fabien.giquel: indigo+

Attachments
The example project with the java files and the comments as well as the generated models (6.37 KB, application/zip)
2010-09-29 15:11 EDT, Björn Tietjens CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Tietjens CLA 2010-09-29 15:06:41 EDT 
Build Identifier: 20100617-1415

when starting modisco on a sample project, I realised that comments are not ported from javamodel to kdmmodel.

in the different classes i added different comments (javadoc, blockcomment, linecomment)

I am not able to find the comments in the kdm model.

in the atl script used I find rules for creating elements for comments.

see also forum: http://www.eclipse.org/forums/index.php?t=rview&goto=629420#msg_629420If


Reproducible: Always

Steps to Reproduce:
1. import src2 project into workspace
2. right click the project and start "modisco > discover kdm code model from java project 
3. view "Src2.javaxmi" and "Src2.kdm"
4. compare "<ownedElements xsi:type="java:ClassDeclaration" originalCompilationUnit="//@compilationUnits.1" name="Component2_Test1">
        <comments xsi:type="java:BlockComment" originalCompilationUnit="//@compilationUnits.1" content="/*&#xA; * Test Comment 1&#xA; */" prefixOfParent="true"/>" from the javaxmi with .kdm
the block comment can not be found.
Comment 1 Björn Tietjens CLA 2010-09-29 15:11:35 EDT 
Created attachment 179888 [details]
The example project with the java files and the comments as well as the generated models

it is a helios eclipse project... created with eclipse modeling + modisco
Comment 2 Fabien Giquel CLA 2010-10-04 12:48:55 EDT 
Hi Bjorn,

a fix of Java2kdm transformation, for translating comments, has just been commited into SVN. It will be available in next MoDisco nightly build.
There are still particular cases where comments are not translated, but in most cases it will do the job.

Fabien.
Comment 3 Hugo Bruneliere CLA 2010-10-05 05:16:30 EDT 
Bug fixed.