Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326563 - Allow access to elementType in ConnectionCreationTool
Summary: Allow access to elementType in ConnectionCreationTool
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.5.0   Edit
Assignee: Lidija Grahek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 13:34 EDT by Lidija Grahek CLA
Modified: 2010-10-14 12:50 EDT (History)
1 user (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2010-09-29 13:40 EDT, Lidija Grahek CLA 		no flags Details | Diff
Patch (2.02 KB, patch)
2010-09-30 15:39 EDT, Lidija Grahek CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lidija Grahek CLA 2010-09-29 13:34:41 EDT 
org.eclipse.gmf.runtime.diagram.ui.tools.ConnectionCreationTool has protected method getElementType() to return elementType associated with that tool. CreationTool (used for shapes), on the other hand, has the same method, but with public access. ConnectionCreationTool should also allow public access to its elementType.
Comment 1 Lidija Grahek CLA 2010-09-29 13:40:40 EDT 
Created attachment 179873 [details]
Patch
Comment 2 Lidija Grahek CLA 2010-09-29 13:42:52 EDT 
Attached the patch. For API compatibility, instead of just changing "protected" to "public" for getElementTyoe(), added a new public method to return getElementType().

Anthony, if it looks OK, I will commit it to to HEAD and R1_4_maintenance.
Comment 3 Anthony Hunter CLA 2010-09-30 11:54:13 EDT 
Does API tooling not complain with an error that you have added a new method and thus broken API compatibility? (i.e. update the plug-in version to 1.5.) .

Please verify and if this is the case we cannot change in 1.4.2, only HEAD.
Comment 4 Lidija Grahek CLA 2010-09-30 15:39:34 EDT 
Created attachment 179993 [details]
Patch

API tooling does complain about added API, so I can't commit this to the maintenance stream. Since that's the case, I attached the patch that changes visibility of getElementType() method from protected to public, and increases version from 1.4.1 to 1.5.0. It will go to HEAD only.
Comment 5 Lidija Grahek CLA 2010-10-14 12:50:19 EDT 
Delivered to HEAD.