Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326541 - Plan Verifier results not checked in reconciler
Summary: Plan Verifier results not checked in reconciler
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 10:06 EDT by DJ Houghton CLA
Modified: 2010-10-27 13:50 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description DJ Houghton CLA 2010-09-29 10:06:27 EDT 
In bug 312254 we released some changes to include a plan verifier which gives products the ability to veto a provisioning plan coming from the reconciler or old update manager code. This is handy in the case (for instance) where a random third-party bundle put in the drop-ins is taken precedence and actually causes the uninstallation of a product.

In bug 270195 we released some changes and refactoring to prepare to handle the case (in 3.7 - bug 313795) where we have some IUs installed via the UI which depend on IUs in the drop-ins, and then the user deletes the bundles from the drop-ins. 

During this refactoring, the code in the ProfileSyncrhonizer which checks the plan status (for potential cancelation by the plan verifier) was accidentally removed. This needs to be added back in the 3.6.x stream.
Comment 1 DJ Houghton CLA 2010-09-29 10:15:40 EDT 
Fixed in R3_6_maintenance branch.
Comment 2 DJ Houghton CLA 2010-10-27 13:50:46 EDT 
Made a modification to the code to be more in line with code elsewhere, and we only fail if there is an error reported.

Old code:
if (!result.getStatus().isOK())
	return result.getStatus();

New code:
if (plan.getStatus().getSeverity() == IStatus.ERROR)
	return plan.getStatus();