Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326504 - [patch] useless composite in NewNodeDialog.createDialogArea
Summary: [patch] useless composite in NewNodeDialog.createDialogArea
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Security (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 05:47 EDT by Martin Monperrus CLA
Modified: 2010-10-01 05:58 EDT (History)
2 users (show)

See Also:

Attachments
patch (997 bytes, text/plain)
2010-09-29 05:48 EDT, Martin Monperrus CLA 		ob1.eclipse: iplog+
Details
Updated patch (2.88 KB, patch)
2010-09-29 09:45 EDT, Oleg Besedin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Monperrus CLA 2010-09-29 05:47:53 EDT 
Build Identifier: 

There is a muddle of new, super and returned Composite in NewNodeDialog.createDialogArea. A patch is attached.

Best regards, --Martin




Reproducible: Always
Comment 1 Martin Monperrus CLA 2010-09-29 05:48:26 EDT 
Created attachment 179817 [details]
patch

patch
Comment 2 Thomas Watson CLA 2010-09-29 08:45:21 EDT 
Thanks Martin,

Oleg, I am not familiar with this.  Does this patch look good?
Comment 3 Oleg Besedin CLA 2010-09-29 09:45:19 EDT 
Created attachment 179842 [details]
Updated patch

(In reply to comment #2)
> Oleg, I am not familiar with this.  Does this patch look good?

Yes, it looks good. I'll update bundle versions as well.
Comment 4 Oleg Besedin CLA 2010-09-29 09:46:35 EDT 
Patch applied to CVS Head. Thanks Martin!
Comment 5 Martin Monperrus CLA 2010-10-01 05:58:31 EDT 
Thanks for answering so fast :-)
--Martin