Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326428 - JPIBootLoader fails to locate AC home if language packs are present
Summary: JPIBootLoader fails to locate AC home if language packs are present
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P2 critical (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: adopter patch
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-28 11:07 EDT by Mike Reid CLA
Modified: 2016-05-05 10:47 EDT (History)
1 user (show)

See Also:
jgwest: review+

Attachments
Patch (2.58 KB, patch)
2010-09-28 11:20 EDT, Mike Reid CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2010-09-28 11:07:20 EDT 
Some downstream products provide translation bundles for some TPTP plugins. In some cases the presence of such a language pack interferes with the JPIBootLoader logic that locates the latest IAC plugin in the workbench.

(On Linux) To locate the latest IAC plugin, JPIBootLoader looks for directories containing the string: org.eclipse.tptp.platform.ac.linux_ia32

If a national language pack is installed, this may end up providing a false positive:

 plugins/org.eclipse.tptp.platform.ac.linux_ia32_4.4.300.v201006031900
 plugins/org.eclipse.tptp.platform.ac.linux_ia32.nl1_4.4.300.v201009152000
 
Depending on the order that the OS lists the directories, we may inadvertently end up using the NL pack as the AC home. This then later on fails to find the required dependencies.

Two workarounds present themselves:

1. Set environment variables as done in the past
2. Uninstall the national language packs
Comment 1 Mike Reid CLA 2010-09-28 11:20:44 EDT 
Created attachment 179758 [details]
Patch

Patch to correct problem. The fix is simply to disambiguate the search string so that it only matches legitimate IAC plugins and excludes NL bundles:

I.e. now we search for: org.eclipse.tptp.platform.ac.linux_ which filters out any NL packs from consideration.
Comment 2 Mike Reid CLA 2010-09-28 11:22:44 EDT 
Jonathan, can you please review the attached patch?
Comment 3 Jonathan West CLA 2010-09-28 14:40:46 EDT 
Patch is good.
Comment 4 Mike Reid CLA 2010-09-28 14:56:24 EDT 
Patch checked into HEAD.
Comment 5 Kathy Chan CLA 2011-02-11 13:45:53 EST 
This defect had been resolved as FIXED for more than 1 month.  Please verify with the latest TPTP 4.7.2 driver.  If this defect is still left unverified by February 25, we'll close it on the originator's behalf.

TPTP 4.7.2 driver can be downloaded from:

http://www.eclipse.org/tptp/home/downloads/?ver=4.7.2
Comment 6 Mike Reid CLA 2011-04-04 10:52:55 EDT 
Closing.