326233 – DsfSession doesn't compile against 3.7

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326233 - DsfSession doesn't compile against 3.7

Summary: DsfSession doesn't compile against 3.7

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-dsf (show other bugs)
Version:	8.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Pawel Piech
QA Contact:	Pawel Piech

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-25 13:21 EDT by Marc-André Laperle
Modified:	2010-09-29 04:55 EDT (History)
CC List:	3 users (show)

See Also:

Flags:	aleherb+eclipse: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc-André Laperle

2010-09-25 13:21:47 EDT

I juts updated my Eclipse SDK to 3.7M2 and DsfSession doesn't compile. It looks like the filter class uses generics now:

boolean org.osgi.framework.Filter.match(Dictionary<String, ?> dictionary)

...
if (entry.getKey().fFilter != null && !entry.getKey().fFilter.match(serviceProperties)) {
...

Comment 1 Pawel Piech

2010-09-27 16:49:44 EDT

Thank you!  I committed the fix.  

Toni, please review.

Comment 2 CDT Genie

2010-09-27 17:23:04 EDT

*** cdt cvs genie on behalf of ppiech ***
Bug 326233 -  DsfSession doesn't compile against 3.7

[*] DsfSession.java 1.18 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf/src/org/eclipse/cdt/dsf/service/DsfSession.java?root=Tools_Project&r1=1.17&r2=1.18

Comment 3 Anton Leherbauer

2010-09-29 04:55:29 EDT

Compiles with 3.7M2.