Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326159 - [design] click on part toolbar needs two clicks on an inactive part
Summary: [design] click on part toolbar needs two clicks on an inactive part
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.4 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 10:45 EDT by Holger Staudacher CLA
Modified: 2010-10-01 04:23 EDT (History)
0 users

See Also:

Attachments
Proposed patch (13.48 KB, patch)
2010-09-30 04:05 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
Updated patch (13.63 KB, patch)
2010-09-30 04:57 EDT, Ivan Furnadjiev CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Staudacher CLA 2010-09-24 10:45:35 EDT 
If a part has a toolbar you need to click twice if the part is inactive. The first click activates the part and the second selects the ToolItem. The item should be clickable wether the part is active or inactive.
Comment 1 Ivan Furnadjiev CLA 2010-09-30 04:05:43 EDT 
Created attachment 179930 [details]
Proposed patch
Comment 2 Ivan Furnadjiev CLA 2010-09-30 04:06:44 EDT 
Holger, please review the patch.
Comment 3 Ivan Furnadjiev CLA 2010-09-30 04:57:26 EDT 
Created attachment 179934 [details]
Updated patch
Comment 4 Holger Staudacher CLA 2010-09-30 09:25:43 EDT 
Hi Ivan.
I think your patch solves the problem. But there is one thing we should be aware of. I talk about multiple views. I had no time to test it with multiple views but we need to before you commit the patch. If an action is set to visible for one view, it should be visible for all others with the same primary id. So, if you set one action to visible and switch the view, it should be visible on this view too. Maybe this will work out of the box with your solution.

Thanks for your work.

Regards Holger
Comment 5 Ivan Furnadjiev CLA 2010-10-01 04:23:02 EDT 
Just tested with multiple views and it works fine - make an action visible in one view, make it visible in all views with the same primary id. Applied patch to CVS HEAD.