326145 – [source lookup] Changing the color of the IP annotation is not reflected immediately in the editor and disassembly

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326145 - [source lookup] Changing the color of the IP annotation is not reflected immediately in the editor and disassembly

Summary: [source lookup] Changing the color of the IP annotation is not reflected imme...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-dsf (show other bugs)
Version:	7.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Anton Leherbauer
QA Contact:	Pawel Piech

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	326655
	Show dependency tree

Reported:	2010-09-24 09:35 EDT by Anton Leherbauer
Modified:	2010-09-30 19:58 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	pawel.1.piech: review+

Attachments
Reuse platform annotation type (8.65 KB, patch) 2010-09-30 06:01 EDT, Anton Leherbauer	aleherb+eclipse: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anton Leherbauer

2010-09-24 09:35:40 EDT

The color is only applied upon close/reopen of the editor/disassembly.
This might be caused by the duplicate IP annotation type in DSF.

Comment 1 Anton Leherbauer

2010-09-30 06:01:24 EDT

Created attachment 179936 [details]
Reuse platform annotation type

This patch removes the DSF specific annotation types and reuses those defined in the platform.
EDC also defines its own set of annotation types causing the same issue.  I'll file a separate bug for that.

Comment 2 CDT Genie

2010-09-30 06:23:01 EDT

*** cdt cvs genie on behalf of aleherbau ***
Bug 326145 - [source lookup] Changing the color of the IP annotation is not reflected immediately in the editor and disassembly

[*] plugin.properties 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/plugin.properties?root=Tools_Project&r1=1.13&r2=1.14
[*] plugin.xml 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/plugin.xml?root=Tools_Project&r1=1.20&r2=1.21

[*] DisassemblyIPAnnotation.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/presentation/DisassemblyIPAnnotation.java?root=Tools_Project&r1=1.2&r2=1.3

[*] InstructionPointerManager.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/sourcelookup/InstructionPointerManager.java?root=Tools_Project&r1=1.3&r2=1.4

Comment 3 Anton Leherbauer

2010-09-30 06:38:04 EDT

I committed the fix.  Pawel, could you review?
I filed bug 326655 for EDC.

Comment 4 Pawel Piech

2010-09-30 19:58:29 EDT

Looks like fine cut and paste action ;-)  Thanks Toni.