Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326137 - Dsf attach session requires project
Summary: Dsf attach session requires project
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.0   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 7.0.2   Edit
Assignee: Marc Khouzam CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 07:29 EDT by Onur Akdemir CLA
Modified: 2010-09-28 11:23 EDT (History)
2 users (show)

See Also:
marc.khouzam: review? (ken.ryall)

Attachments
Fix for HEAD (4.22 KB, patch)
2010-09-26 20:43 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
Fix for 7_0 (1.89 KB, patch)
2010-09-28 10:59 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Onur Akdemir CLA 2010-09-24 07:29:28 EDT 
Build Identifier: I20100608-0911

Attach application debug configuration requires project name , this shouldn't happen . (This is not a case with galileo) . Eclipse CVS Head has this bug.



Reproducible: Always

Steps to Reproduce:
1.Open Debug Configuration
2.Click "C/C++ Attach to Application" wizard 
3.Try with an empty project name.
Comment 1 Marc Khouzam CLA 2010-09-26 20:41:27 EDT 
This regression has to do with the refactoring of AbstractCLaunchDelegate2
Comment 2 Marc Khouzam CLA 2010-09-26 20:43:43 EDT 
Created attachment 179593 [details]
Fix for HEAD

AbstractCLaunchDelegate2 has a member called 'requireCProject', which should be set to false for a DSF-GDB attach session.

This patch does this.

Committed to HEAD.
Comment 3 Marc Khouzam CLA 2010-09-26 20:45:49 EDT 
Ken, can you review this change?
Comment 4 Marc Khouzam CLA 2010-09-26 21:02:58 EDT 
Also committed to the 7_0 branch for 7.0.2
Comment 5 CDT Genie CLA 2010-09-26 21:23:04 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 326137: Allow DSF-GDB attach session to work without a project or binary.

[*] LaunchUtils.java 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java?root=Tools_Project&r1=1.15&r2=1.16
[*] GdbLaunchDelegate.java 1.19 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunchDelegate.java?root=Tools_Project&r1=1.18&r2=1.19
[+] GdbAttachLaunchDelegate.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbAttachLaunchDelegate.java?root=Tools_Project&revision=1.1&view=markup

[*] plugin.xml 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/plugin.xml?root=Tools_Project&r1=1.6&r2=1.7

[*] LaunchUtils.java 1.12.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/LaunchUtils.java?root=Tools_Project&r1=1.12&r2=1.12.2.1
[*] GdbLaunchDelegate.java 1.16.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunchDelegate.java?root=Tools_Project&r1=1.16&r2=1.16.2.1
[+] GdbAttachLaunchDelegate.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbAttachLaunchDelegate.java?root=Tools_Project&revision=1.1&view=markup

[*] plugin.xml 1.5.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/plugin.xml?root=Tools_Project&r1=1.5&r2=1.5.2.1
Comment 6 CDT Genie CLA 2010-09-27 11:23:04 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 326137: Allow DSF-GDB attach session to work without a project or binary (add missing @since in new constructor)

[*] GdbLaunchDelegate.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbLaunchDelegate.java?root=Tools_Project&r1=1.19&r2=1.20
Comment 7 CDT Genie CLA 2010-09-27 14:23:02 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 326137: Missing @since tag

[*] GdbAttachLaunchDelegate.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/launching/GdbAttachLaunchDelegate.java?root=Tools_Project&r1=1.1&r2=1.2
Comment 8 Marc Khouzam CLA 2010-09-28 10:36:28 EDT 
(In reply to comment #4)
> Also committed to the 7_0 branch for 7.0.2

I had to revert this fix because it broke the API.  I'll try to find a solution that does not change the API
Comment 9 Marc Khouzam CLA 2010-09-28 10:59:19 EDT 
Created attachment 179755 [details]
Fix for 7_0

This fix reverts to use the verifyCProject method that DSF-GDB was using in Galileo.  It does the same thing as the new method, but allows for an empty project name.  It is up to the launch tab to prevent this from happening for launches that are not 'attach'.

Committed to 7_0