Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326134 - Content assist proposals are missing additional info
Summary: Content assist proposals are missing additional info
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: Web (show other bugs)
Version: 3.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Jacek Pospychala CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 06:52 EDT by Jacek Pospychala CLA
Modified: 2010-09-28 17:29 EDT (History)
1 user (show)

See Also:
cmjaun: review+
thatnitind: review+

Attachments
patch (1.89 KB, patch)
2010-09-24 07:38 EDT, Jacek Pospychala CLA 		thatnitind: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2010-09-24 06:52:02 EDT 
In HTML (or PHP) editor, JavaScript completion proposals are missing additional info with JSDoc - the yellowish tooltip window, that should normally show up on the right of completion proposals list.
Everything works fine in JavaScript editor.

The difference between those editors is that HTML editor uses JSDTCompletionProposals, whereas JS editor uses JavaCompletionProposals.
JSDTCompletionProposal extends JavaCompletionProposal, altough the additionalInfo is never set and super.additionalInfo is not used as well.
Comment 1 Jacek Pospychala CLA 2010-09-24 07:38:41 EDT 
Created attachment 179515 [details]
patch

make JSDTCompletionProposal.getAdditionalProposalInfo(IProgressMonitor) work the same as JSDTCompletionProposal.getAdditionalProposalInfo()
Comment 2 Jacek Pospychala CLA 2010-09-24 07:39:18 EDT 
Chris,
want to review? :-)
Comment 3 Chris Jaun CLA 2010-09-28 10:20:59 EDT 
Looks good to me.

Will get Nitin's approval and check into 3.2.3 and HEAD.
Comment 4 Nitin Dahyabhai CLA 2010-09-28 17:29:28 EDT 
Checked into maintenance and HEAD.  Thanks, Jacek!