Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326132 - DefaultHostContainerFinder uses ecf.generic.server as default even if bundle org.eclipse.ecf.provider.remoteservice is not deployed
Summary: DefaultHostContainerFinder uses ecf.generic.server as default even if bundle ...
Status: NEW
Alias: None
Product: ECF
Classification: RT
Component: ecf.remoteservices (show other bugs)
Version: 3.3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-24 05:58 EDT by Markus Kuppe CLA
Modified: 2010-10-02 07:55 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2010-09-24 05:58:34 EDT 
org.eclipse.ecf.internal.osgi.services.distribution.Activator defines ecf.generic.server as the ECF default. This is totally acceptable if org.eclipse.ecf.provider.remoteservice is deployed. However, if this bundle is missing in the current runtime, DefaultHostContainerFinder fails to create a default remote service container.
Maybe as part of bug #324215 we want to change the current implementation to set the default container dynamically (e.g. based on what is deployed...).
Comment 1 Scott Lewis CLA 2010-09-24 10:39:43 EDT 
(In reply to comment #0)
> org.eclipse.ecf.internal.osgi.services.distribution.Activator defines
> ecf.generic.server as the ECF default. This is totally acceptable if
> org.eclipse.ecf.provider.remoteservice is deployed. However, if this bundle is
> missing in the current runtime, DefaultHostContainerFinder fails to create a
> default remote service container.
> Maybe as part of bug #324215 we want to change the current implementation to
> set the default container dynamically (e.g. based on what is deployed...).

I'm not clear on exactly how we are going to do this, but it would be implemented here on line 170 of

org.eclipse.ecf.internal.osgi.services.distribution.Activator

The current mechanism allows the use of a system property to set the default...I guess that could be used.  Or something more clever is ok with me...I just don't know what that would be off the top of my head.
Comment 2 Scott Lewis CLA 2010-09-24 10:41:02 EDT 
I don't really understand how this bug blocks bug 324215.
Comment 3 Markus Kuppe CLA 2010-10-02 07:55:09 EDT 
(In reply to comment #1)
> (In reply to comment #0)
> > org.eclipse.ecf.internal.osgi.services.distribution.Activator defines
> > ecf.generic.server as the ECF default. This is totally acceptable if
> > org.eclipse.ecf.provider.remoteservice is deployed. However, if this bundle is
> > missing in the current runtime, DefaultHostContainerFinder fails to create a
> > default remote service container.
> > Maybe as part of bug #324215 we want to change the current implementation to
> > set the default container dynamically (e.g. based on what is deployed...).
> 
> I'm not clear on exactly how we are going to do this, but it would be
> implemented here on line 170 of

DefaultHostContainerFinder could simply perform a lookup in the OSGi service registry for IRemoteServiceContainer and use the one with the highest service.rank.