Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 326119 - Repository credentials are overwritten during repository settings validation
Summary: Repository credentials are overwritten during repository settings validation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P2 major (vote)
Target Milestone: 3.10   Edit
Assignee: Sam Davis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 413550 (view as bug list)
Depends on:
Blocks: 278474
  Show dependency tree
 
Reported: 2010-09-24 03:26 EDT by Jacek Jaroczynski CLA
Modified: 2013-10-07 22:08 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Jaroczynski CLA 2010-09-24 03:26:53 EDT 
Build Identifier: 

Steps to reproduce:
* open valid task repo
* uncheck 'save password'
* click 'validate'
* click 'cancel'
* open task repo again ('save password' is checked but password is missing)

The bug was introduced together with SecureStorage usage for password.

Reproducible: Always
Comment 1 Jacek Jaroczynski CLA 2010-09-30 03:44:10 EDT 
I applied workaround for JIRA and Bamboo repositories but the root problem still exists and affects other type of repos.
When user opens repo, uncheck 'save password' and hit 'validate', temporary repository is created, password is removed from Secure Storage for given repository url and put in transient properties for the repo. After the validate process is finished, temporary repo is gone together with password stored in transient properties. There is no password in Secure Storage. The password is still available only in dialog box. When user hits 'Cancel' the password is lost.
Comment 2 Steffen Pingel CLA 2011-04-05 14:55:45 EDT 
Thanks for the detailed steps. We should consider a fix as part of bug 326119.
Comment 3 Sam Davis CLA 2013-01-16 14:15:42 EST 
I've created the following review:

9715: 326119: Task Repository does not remember password [I0f8becdc]
https://git.eclipse.org/r/#/c/9715/
Comment 4 Sam Davis CLA 2013-07-23 13:17:28 EDT 
*** Bug 413550 has been marked as a duplicate of this bug. ***
Comment 5 Sam Davis CLA 2013-07-23 13:20:08 EDT 
It seems that this now happens when using the keyring too.
Comment 6 Sam Davis CLA 2013-07-23 13:45:28 EDT 
Also, the issue is not just when unchecking save password but rather that validating updates the credential store.
Comment 7 Steffen Pingel CLA 2013-10-07 22:03:13 EDT 
The fix has been merged into master and will be available with the next build: https://hudson.eclipse.org/hudson/view/Mylyn/job/mylyn-release/217/console.
Comment 8 Sam Davis CLA 2013-10-07 22:08:06 EDT 
Thanks Steffen!