Description Oisín Mac Fhearaí 2010-09-23 10:38:04 EDT

Build Identifier: 20100218-1602

The "Use 'MessageFormat' for string concatenation" option given by Quick Fix in the context of a string concatenation with the + operator will give up if it encounters unparenthesised numeric arithmetic.
It's a good idea to parenthesise such expressions anyway, but it would be nice if the case was handled transparently.

Reproducible: Always

Steps to Reproduce:
1. Write: String test = "hello " + 4*2 + "a " + 3 + " c" + 4;
2. Put the cursor at the start of the string (or somewhere where the Quick Fix expects it) and open the quick fix menu (ctrl+1)
3. Select "Use 'MessageFormat' for string concatenation" (or StringBuilder)

Expected result:

MessageFormat.format("hello {0}a {1} c{2}", 4*2, 3, 4)

Actual result:

MessageFormat.format("{0}{1}", "hello " + 4*2 + "a " + 3 + " c", 4)

Workaround: Parenthesise the problem expression.

String test2 = "hello " + (4*2) + "a " + 3 + " c" + 4;