Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325894 - Protect EARUtilities.getJ2EEModuleReferences from NPE
Summary: Protect EARUtilities.getJ2EEModuleReferences from NPE
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 3.2.2 P   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 14:53 EDT by Jason Sholl CLA
Modified: 2010-10-04 14:35 EDT (History)
1 user (show)

See Also:
cbridgha: review+

Attachments
patch (22.18 KB, patch)
2010-09-21 14:57 EDT, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2010-09-21 14:53:29 EDT 
Slight change in behavior from previous versions is now causing the following NPE:

java.lang.NullPointerException
      at org.eclipse.jst.j2ee.project.EarUtilities.getEARLibDir(EarUtilities.java:413)
      at org.eclipse.jst.j2ee.project.EarUtilities.getJ2EEModuleReferences(EarUtilities.java:86)
Comment 1 Jason Sholl CLA 2010-09-21 14:57:43 EDT 
Created attachment 179335 [details]
patch

Protects against above NPE, and all others, and also updates javadoc.  No change in behavior.
Comment 2 Chuck Bridgham CLA 2010-09-29 10:13:28 EDT 
approved
Comment 3 Jason Sholl CLA 2010-09-29 12:16:39 EDT 
code checked into 32M and HEAD for WTP 3.2.3 and 3.3 respectively.
Comment 4 Carl Anderson CLA 2010-10-04 14:35:14 EDT 
Committed to R3_2_2_patches