Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325849 - [Model] Need an MArea element
Summary: [Model] Need an MArea element
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 324957 325864
  Show dependency tree
 
Reported: 2010-09-21 09:32 EDT by Eric Moffatt CLA
Modified: 2010-10-26 15:27 EDT (History)
1 user (show)

See Also:

Attachments
patch (45.25 KB, patch)
2010-09-21 10:03 EDT, Thomas Schindl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2010-09-21 09:32:08 EDT 
I've gotten an initial implementation for an Editor Area up by hacking the SashRenderer to look for a specific 'area' tag but I don't think that's the right way to go.

We need labeling info for areas, both to show in the UI as well as when the area is minimized...

I'd say a new element MArea that inherits both MPSC & MUILabel should do it...??
Comment 1 Thomas Schindl CLA 2010-09-21 09:40:57 EDT 
Some initial thoughts:
a) Naming: MArea - not sure i like the name
b) Why not simply adding MUILabel to PSC?
Comment 2 Thomas Schindl CLA 2010-09-21 10:03:19 EDT 
Created attachment 179314 [details]
patch

An initial version - is my assumption correct that UILabel is needed to display the area in the Trim? 

I've added the MArea to the advanced package - is that ok with you?
Comment 3 Thomas Schindl CLA 2010-09-21 10:52:40 EDT 
released to head
Comment 4 Eric Moffatt CLA 2010-09-22 14:03:54 EDT 
Tom, I've made a slight change...the EClass in the ecore should just have been 'Area'. This lead to an MMArea interface backed by an MAreaImpl... which is different to the other classes.

Committed in >20100922. Rename the new EClass 'Area' to bring it in line with the rest of the model.
Comment 5 Eric Moffatt CLA 2010-10-26 15:27:01 EDT 
Verified in I20101026-0203.