Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325843 - VSH command does not print correct line endings
Summary: VSH command does not print correct line endings
Status: CLOSED FIXED
Alias: None
Product: Virgo
Classification: RT
Component: unknown (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: ---   Edit
Assignee: Steve Powell CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 08:41 EDT by Hristo Iliev CLA
Modified: 2010-09-28 05:54 EDT (History)
1 user (show)

See Also:

Attachments
Added standard line ending in VSH help (1.58 KB, patch)
2010-09-21 11:03 EDT, Hristo Iliev CLA 		zteve.powell: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hristo Iliev CLA 2010-09-21 08:41:44 EDT 
Build Identifier: 2.1.0.M04-incubation

On Windows systems VSH command uses "\n" as line ending instead of "line.separator" which causes misplaced output. Since no /r is printed the output just produces new line without returning the carret to the start of the line:

---Eclipse Runtime commands---
        diag - Displays unsatisfied constraints for the specified bundle(s).
        enableBundle - enable the specified bundle(s)
        disableBundle - disable the specified bundle(s)
        disabledBundles - list disabled bundles in the system
        vsh - Virgo shell commands; 'vsh help' to list available commands
                                                                         ---Controlling the Console---
        more - More prompt for console output
        disconnect - Disconnects from telnet session

Reproducible: Always

Steps to Reproduce:
1. connect to Virgo with telnet
2. issue help command
Comment 1 Hristo Iliev CLA 2010-09-21 11:03:23 EDT 
Created attachment 179318 [details]
Added standard line ending in VSH help
Comment 2 Steve Powell CLA 2010-09-28 05:36:55 EDT 
Comment on attachment 179318 [details]
Added standard line ending in VSH help

SHA:	15812b2fdf686bb8faab7d07d04a753cdc819047
Author:	Hristo Iliev <hristo.iliev@sap.com>
Date:	Tue Sep 28 2010 10:34:27 GMT+0100 (BST)
Committer:	Steve Powell <spowell@vmware.com>
Commit Date:	Tue Sep 28 2010 10:35:04 GMT+0100 (BST)
Subject:	Bug 325843 - VSH command does not print correct line endings
Comment 3 Steve Powell CLA 2010-09-28 05:37:46 EDT 
Hristo, Please confirm here you wrote 100% of this patch and are permitted to contribute it to Eclipse, as usual.
Thanks.
Comment 4 Hristo Iliev CLA 2010-09-28 05:53:09 EDT 
I confirm that I wrote 100% of the patch and I have the right to contribute it
to Eclipse.
Comment 5 Steve Powell CLA 2010-09-28 05:54:23 EDT 
Many thanks.