Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325825 - [preferences] make it easier to set font for all text based editors
Summary: [preferences] make it easier to set font for all text based editors
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 327510
  Show dependency tree
 
Reported: 2010-09-21 06:05 EDT by Dani Megert CLA
Modified: 2010-10-12 02:40 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-09-21 06:05:36 EDT
3.6.

Currently the editor fonts default to 'Text Font' which is not too intuitive and there is no 'Text Editor' font. Also, when a font points to a default font (set to default: xyz), there's no direct/simple way to just edit that default font or at least jump to it in the preference page.
Comment 1 Dani Megert CLA 2010-10-01 09:56:49 EDT
Things we can improve:

1. Make sure entering "font", "text editor font" and "text editor font" into 
   the preference search field finds the 'Colors and Fonts' and the 'Text 
   Editors' page.

2. On the 'Colors and Font' preference page add a button that allows directly
   edit the inherited font (e.g. 'Text Font' when 'Java Editor Font' is 
   selected).

3. At the top of the 'Text Editors' page add a link to 'Colors and Fonts' and
   if possible, directly select the 'Text Font'.


Boris, do you agree with this? Any other ideas?
Comment 2 Dani Megert CLA 2010-10-01 09:57:15 EDT
>1. Make sure entering "font", "text editor font" and "text editor font" into 
1. Make sure entering "font", "editor font" and "text editor font" into
Comment 3 Boris Bokowski CLA 2010-10-05 08:56:05 EDT
(In reply to comment #1)
> Boris, do you agree with this? Any other ideas?

I agree. Note that the "Text Editors" preference page already has a link to "Colors and Fonts", but at the bottom - would you just move this to the top? Or move it up above the "Appearance color options" group? I like the idea to preselect the Text Font entry. We could also:

4. Take the description into account for the filtered tree on the "Colors and Fonts" preference page, so that entering "text editor" would not remove the "Text Font" entry.
5. (Not sure if this can be done without major re-architecting:) add entries on the "Text Editors" preference page for other colors and fonts that would normally be set on the "Colors and Fonts" preference page, so that they can be edited there, too.
6. The changes we make to the "Text Editors" preference page should probably be made to the "Java > Editor" preference page, too.
Comment 4 Dani Megert CLA 2010-10-05 09:13:27 EDT
(In reply to comment #3)
> (In reply to comment #1)
> > Boris, do you agree with this? Any other ideas?
> 
> I agree. Note that the "Text Editors" preference page already has a link to
> "Colors and Fonts", but at the bottom - would you just move this to the top? Or
> move it up above the "Appearance color options" group? 
I would probably add a second one at the top of the page, e.g. "The fonts for textual editors can be configured on the 'Colors and Fonts' preference page". The second link would preselect something else than the text font.

We could also:
> 
> 4. Take the description into account for the filtered tree on the "Colors and
> Fonts" preference page, so that entering "text editor" would not remove the
> "Text Font" entry.
Good idea. I'll see whether there's an easy way to do this.

> 5. (Not sure if this can be done without major re-architecting:) add entries >
>on
> the "Text Editors" preference page for other colors and fonts that would
> normally be set on the "Colors and Fonts" preference page, so that they can be
> edited there, too.
I was thinking about that too, but given we would actually like to move more stuff from the separate pref pages to the 'Colors and Fonts' page (currently blocked by 180935), I suggested 3.

> 6. The changes we make to the "Text Editors" preference page should probably
> be made to the "Java > Editor" preference page, too.
+1.
Comment 5 Dani Megert CLA 2010-10-05 10:12:51 EDT
Fixed 1. in HEAD and renamed "Text Font" to "Text and Editor Font".
Comment 6 Dani Megert CLA 2010-10-07 07:17:47 EDT
>3. At the top of the 'Text Editors' page add a link to 'Colors and Fonts' and
>   if possible, directly select the 'Text Font'.
Done (including selection of the font).

>6. The changes we make to the "Text Editors" preference page should probably be
>made to the "Java > Editor" preference page, too.
Done.
Comment 7 Dani Megert CLA 2010-10-08 03:30:19 EDT
>4. Take the description into account for the filtered tree on the "Colors and
>Fonts" preference page, so that entering "text editor" would not remove the
>"Text Font" entry.
Done and reverted:
  >renamed "Text Font" to "Text and Editor Font".
since this is no longer needed and it's better to keep the old/known font name.
Comment 8 Dani Megert CLA 2010-10-08 07:01:57 EDT
>2. On the 'Colors and Font' preference page add a button that allows directly
>   edit the inherited font (e.g. 'Text Font' when 'Java Editor Font' is 
>   selected).
Done.

I also fixed the content provider in order to fix issues with nested definitions in the same category.