325783 – [formatter] Function call arguments' indentation is wrong if there is a templated argument

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325783 - [formatter] Function call arguments' indentation is wrong if there is a templated argument

Summary: [formatter] Function call arguments' indentation is wrong if there is a templ...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-editor (show other bugs)
Version:	7.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	7.0.2
Assignee:	Anton Leherbauer
QA Contact:	Anton Leherbauer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-09-20 14:54 EDT by Dmitry Katsubo
Modified:	2010-10-14 07:23 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
Result of actual formatting (289 bytes, application/octet-stream) 2010-09-20 14:54 EDT, Dmitry Katsubo	no flags	Details
Result of expected formatting (320 bytes, application/octet-stream) 2010-09-20 14:55 EDT, Dmitry Katsubo	no flags	Details
Formatting rules (16.17 KB, text/xml) 2010-09-20 14:55 EDT, Dmitry Katsubo	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dmitry Katsubo

2010-09-20 14:54:15 EDT

Build Identifier: CDT Build id: 201006141710

If the list of arguments of the function contains arguments with templates, this confuses the formatter. See attached examples.

Reproducible: Always

Comment 1 Dmitry Katsubo

2010-09-20 14:54:50 EDT

Created attachment 179265 [details]
Result of actual formatting

Comment 2 Dmitry Katsubo

2010-09-20 14:55:10 EDT

Created attachment 179266 [details]
Result of expected formatting

Comment 3 Dmitry Katsubo

2010-09-20 14:55:28 EDT

Created attachment 179267 [details]
Formatting rules

Comment 4 Anton Leherbauer

2010-10-14 07:04:17 EDT

Fixed in HEAD and 7.0.2.

Comment 5 CDT Genie

2010-10-14 07:23:02 EDT

*** cdt cvs genie on behalf of aleherbau ***
Bug 325783 - [formatter] Function call arguments' indentation is wrong if there is a templated argument

[*] CodeFormatterVisitor.java 1.81 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/formatter/CodeFormatterVisitor.java?root=Tools_Project&r1=1.80&r2=1.81

[*] CodeFormatterTest.java 1.56 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/CodeFormatterTest.java?root=Tools_Project&r1=1.55&r2=1.56

[*] CodeFormatterVisitor.java 1.78.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.core/src/org/eclipse/cdt/internal/formatter/CodeFormatterVisitor.java?root=Tools_Project&r1=1.78.2.1&r2=1.78.2.2

[*] CodeFormatterTest.java 1.54.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui.tests/ui/org/eclipse/cdt/ui/tests/text/CodeFormatterTest.java?root=Tools_Project&r1=1.54.2.1&r2=1.54.2.2