Community
Participate
Working Groups
Created attachment 179252 [details] dialog showing the duplicate/missing icons Legend dialog has some missing icons and some uninteded repetition. Node Icons: includes two up's, two down's, two errors (see attachment legend_error.png
Created attachment 179254 [details] Old original legend showing (presumably) what's missing Old original legend is attached.
fix the obviously incorrect ones in ptp_40 branch. will do HEAD too.
Created attachment 179261 [details] Here's what it looks like now, as fixed
committed to HEAD too. Also removed some unused messages in LegendDialog. I'll assume that the other icons that were in the old one no longer belong. If they are still missing and need to be there, let me know and I'll find/fix them too. Otherwise I'll consider this fixed.
The legend dialog also needs to be extensible. The other icons are now resource manager specific, so the resource managers need a way of contributing the icons and description to the dialog.
I assume ResMgrs need to be able to add icons to any category (group of icons). Do we need annotations about which ResMgr each icon comes from? So would an extn point that allows a contribution of: Icon image, category to add it to, Icon name ("starting" etc), and which ResMgr it applies to be the right idea? And a UI that looks something like this makes sense? (new row for an icon looks like) ICON, Name, (ResMgr) e.g. (*=icon) * DISCOMBOBULATED (Foo Res Mgr) This does the simple thing of putting the Res Mgr that the status icon contribution comes from in parentheses. Comments? And what is a Res Mgr that would be a good first implementation?
(In reply to comment #6) > I assume ResMgrs need to be able to add icons to any category (group of icons). > Do we need annotations about which ResMgr each icon comes from? > So would an extn point that allows a contribution of: > Icon image, category to add it to, Icon name ("starting" etc), and which > ResMgr it applies to > be the right idea? > And a UI that looks something like this makes sense? (new row for an icon looks > like) > ICON, Name, (ResMgr) > e.g. (*=icon) > * DISCOMBOBULATED (Foo Res Mgr) > > This does the simple thing of putting the Res Mgr that the status icon > contribution comes from in parentheses. > Comments? > > And what is a Res Mgr that would be a good first implementation? It's a little bit more complicated because of the new flexible model Randy is working on, which will allow a RM to define any number of levels (not just Machine, Node, etc.) So each RM can effectively provide it's own model with elements that are independent of other RM's. To cater for this, dialog is going to need to be RM-specific, or at least have a section for each RM. Rather than a new extension point, I would suggest modifying the existing IRuntimeModelPresentation interface (used by the runtimeModelPresentation extension point) to provide a method that creates the dialog. I would also suggest removing the button on the toolbar and instead adding a submenu to the Help menu. This submenu could have a submenu for each RM (e.g. Help>Show Legend>Open MPI, etc.)
The legend dialog is now redundant and should be removed. The only icons still used are by the debugger, which are already described in the help documentation.
Removed from Kepler
