Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325627 - API tests block with dialog
Summary: API tests block with dialog
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
: 325625 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-09-17 12:44 EDT by Paul Webster CLA
Modified: 2010-09-20 12:21 EDT (History)
3 users (show)

See Also:

Attachments
Saveable dialog (11.60 KB, image/png)
2010-09-17 12:44 EDT, Paul Webster CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-09-17 12:44:05 EDT 
Created attachment 179133 [details]
Saveable dialog

While running org.eclipse.ui.tests.api.IViewPartTest.testOpenAndCloseSaveNotNeeded() it opens a dialog (it's not supposed to) and blocks the tests.
Comment 1 Remy Suen CLA 2010-09-17 12:45:39 EDT 
*** Bug 325625 has been marked as a duplicate of this bug. ***
Comment 2 Remy Suen CLA 2010-09-17 12:57:52 EDT 
From bug 325625 comment 1:
The part is hidden but when the window tries to close itself, we query for all
dirty parts and find this part so we try to prompt for a save.

----------

It seems to me that the EPS should explicitly invoke part.setDirty(false) when a part is hidden?
Comment 3 Remy Suen CLA 2010-09-20 12:21:17 EDT 
Fixed in CVS HEAD.

(In reply to comment #2)
> It seems to me that the EPS should explicitly invoke part.setDirty(false) when
> a part is hidden?

In hindsight, this is a terribly dumb idea so I've done something else.