Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325595 - [editor] No error icon in editor left ruler before save
Summary: [editor] No error icon in editor left ruler before save
Status: CLOSED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-17 10:03 EDT by Ian Tewksbury CLA
Modified: 2010-11-18 08:48 EST (History)
1 user (show)

See Also:
cmjaun: review+
thatnitind: review+

Attachments
Fix Patch (4.80 KB, patch)
2010-09-17 10:05 EDT, Ian Tewksbury CLA 		no flags Details | Diff
vertical ruler image - regular (4.92 KB, image/png)
2010-09-29 18:25 EDT, Nitin Dahyabhai CLA 		no flags Details
vertical ruler image - rollover (5.92 KB, image/png)
2010-09-29 18:26 EDT, Nitin Dahyabhai CLA 		no flags Details
Image of Java overlapping markers (4.43 KB, image/png)
2010-09-30 08:54 EDT, Ian Tewksbury CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2010-09-17 10:03:37 EDT 
This bug is essentially the same the JDT Bug 129588.

In JSDT error markers are not showing up in the left ruler before the file is saved.  The fix for JSDT is the same as the fix used for JDT.
Comment 1 Ian Tewksbury CLA 2010-09-17 10:05:14 EDT 
Created attachment 179116 [details]
Fix Patch

This is essentially the same patched used for the JDT bug.  Code just needed to be added to handle ERROR/WARNING/INFO markers because as of right now we only handle quickfix markers.
Comment 2 Nitin Dahyabhai CLA 2010-09-29 18:25:41 EDT 
Created attachment 179907 [details]
vertical ruler image - regular
Comment 3 Nitin Dahyabhai CLA 2010-09-29 18:26:51 EDT 
Created attachment 179908 [details]
vertical ruler image - rollover

Attaching images showing that the image shown during rollover affordance doesn't match the regular image shown in the ruler as it does in the Java Editor.  Clicking on the rolled over image doesn't invoke the accompanying QuickFix, either.
Comment 4 Ian Tewksbury CLA 2010-09-30 08:39:54 EDT 
(In reply to comment #3)
> Created an attachment (id=179908) [details]
> vertical ruler image - rolloever
> 
> Attaching images showing that the image shown during rollover affordance
> doesn't match the regular image shown in the ruler as it does in the Java
> Editor.  Clicking on the rolled over image doesn't invoke the accompanying
> QuickFix, either.

I am not sure how you are getting that rolled over image.  But from what I can tell there is an error marker for the "chris()" method not existing that is being overlayed over the quick fix error marker for the "v" variable not existing.

And I verified the same thing happens in Java.  I will attach screen shot.

Also with the patch applied when I click on the error marker I do get quick fix suggestions.
Comment 5 Ian Tewksbury CLA 2010-09-30 08:54:22 EDT 
Created attachment 179946 [details]
Image of Java overlapping markers

imaages showing that JDT does the same thing when there is an error and a quick fix error on the same line.
Comment 6 Nitin Dahyabhai CLA 2010-11-01 17:27:24 EDT 
Committed to 3.2 maintenance and HEAD.
Comment 7 Ian Tewksbury CLA 2010-11-18 08:48:37 EST 
Verified in latest 3.2.3 build.