Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325557 - Associating a Launch with Perspective "None" is not persisted
Summary: Associating a Launch with Perspective "None" is not persisted
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-17 05:16 EDT by Martin Oberhuber CLA
Modified: 2010-10-15 11:32 EDT (History)
2 users (show)

See Also:

Attachments
Patch fixing the issue (2.90 KB, patch)
2010-10-11 08:13 EDT, Martin Oberhuber CLA 		darin.eclipse: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2010-09-17 05:16:21 EDT 
CQ:WIND00233281

Build ID: I20100608-0911 (Eclipse 3.6)

Steps to Reproduce:
1. Window > Preferences > Run/Debug > Perspectives
2. Pick any Launch type, change associated perspective for Debug 
   from "Debug" to "None", press OK
3. Quit and Restart --> Associated Perspective is back to "Debug"

This is a usability problem since in our product we have multiple perspectives tuned for debugging, which a user chooses before launching. Being thrown out of their chosen perspective on launch is perceived as disruptive.
Comment 1 Martin Oberhuber CLA 2010-10-11 08:13:17 EDT 
Created attachment 180595 [details]
Patch fixing the issue

Here is a patch fixing the issue, could this be considered?

Problem was that PerspectiveManager#generatePerspectiveXML() explicitly didn't persist the "None" setting. Now, the patch suppresses persisting the default perspective (which probably was the original intention of this code).
Comment 2 Darin Wright CLA 2010-10-15 10:58:21 EDT 
Comment on attachment 180595 [details]
Patch fixing the issue

Thanks for the patch. Applied.
Comment 3 Darin Wright CLA 2010-10-15 10:58:41 EDT 
Fixed.
Comment 4 Pawel Piech CLA 2010-10-15 11:09:10 EDT 
(In reply to comment #3)
> Fixed.

Thanks Darin, is it OK if I backport it to 3.6 stream?
Comment 5 Darin Wright CLA 2010-10-15 11:15:43 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Fixed.
> Thanks Darin, is it OK if I backport it to 3.6 stream?

Sure. I guess you could clone this bug to keep track of it in 3.6.2, or just re-target this one for 3.6.2.
Comment 6 Pawel Piech CLA 2010-10-15 11:32:06 EDT 
I committed the fix for 3.6.2.