Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325533 - [content assist] Can't find JSDoc for type name proposals with '.' in the qualified name
Summary: [content assist] Can't find JSDoc for type name proposals with '.' in the qua...
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.2.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 18:21 EDT by Nitin Dahyabhai CLA
Modified: 2010-09-28 13:56 EDT (History)
1 user (show)

See Also:
cmjaun: review+

Attachments
proposed patch (1.35 KB, patch)
2010-09-16 18:24 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2010-09-16 18:21:13 EDT 
Now that we store simple names in the index as well as qualified names (bug 305694), I'm getting proposals for the simple name.  The problem is that the associated signature is for the simple name only, and we can't find a source reference and nearby doc for it since it's not the proper qualified name.
Comment 1 Nitin Dahyabhai CLA 2010-09-16 18:24:04 EDT 
Created attachment 179078 [details]
proposed patch
Comment 2 Chris Jaun CLA 2010-09-28 11:30:49 EDT 
What scenario triggers this? I'm not sure how to test this one out, though the fix itself looks fine.
Comment 3 Nitin Dahyabhai CLA 2010-09-28 13:35:20 EDT 
If we have a type named "foo.bar" and we attempt to do content assist for allocation, the proposal for "bar" can't find its doc because we don't have an a type in the model simply named "bar".  Since the proposal includes the full name, "foo.bar", it tries to use that as a fallback type name should the name in the signature not be found.
Comment 4 Nitin Dahyabhai CLA 2010-09-28 13:51:40 EDT 
Applied to HEAD.
Comment 5 Chris Jaun CLA 2010-09-28 13:56:24 EDT 
Checked into 3.2.3 and HEAD.