Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325529 - TaglibIndex cache turning over references too frequently
Summary: TaglibIndex cache turning over references too frequently
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2 P   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 16:59 EDT by Nick Sandonato CLA
Modified: 2010-10-06 11:30 EDT (History)
3 users (show)

See Also:
thatnitind: review+

Attachments
patch (3.47 KB, patch)
2010-09-16 18:14 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-09-16 16:59:05 EDT 
Currently, the LimitedHashMap that's regulating the number of ProjectDescriptions that are in memory at any given time is turning over references too frequently. Recreating a projectDescription is a fairly expensive process and can easily bog down the CPU.

It's probably best if we relax having a limit on the cache.
Comment 1 Nick Sandonato CLA 2010-09-16 18:14:39 EDT 
Created attachment 179077 [details]
patch

Removes the cache limit from the TaglibIndex
Comment 2 Nitin Dahyabhai CLA 2010-09-17 00:29:21 EDT 
Indeed, plus it shouldn't have extremely negative consequences since there is still a low memory listener in place.
Comment 3 Carsten Pfeiffer CLA 2010-09-24 04:26:43 EDT 
We're also experiencing this performance problem. In which release will this be fixed? (I don't get what "3.2.2 P" as target milestone means.) I understand that the patch was committed to HEAD, but I don't see it in the 3.2 branch.

Thanks,
Carsten
Comment 4 Nick Sandonato CLA 2010-09-24 09:43:28 EDT 
3.2.2, which is the first service release of WTP, is all but shutdown at this point. We'll have to wait until everything has been tagged and ready for 3.2.2, then we'll be able to start checking things in for 3.2.3, which will correspond to SR2.
Comment 5 Carsten Pfeiffer CLA 2010-09-24 09:46:06 EDT 
Great, I'm happy to hear that it'll get fixed before 3.3 :-)

Thanks,
Carsten
Comment 6 Carl Anderson CLA 2010-10-04 14:20:20 EDT 
Committed to R3_2_2_patches
Comment 7 Nick Sandonato CLA 2010-10-06 11:23:12 EDT 
(In reply to comment #5)
> Great, I'm happy to hear that it'll get fixed before 3.3 :-)
> 
> Thanks,
> Carsten

Hi Carsten,

Please see Bug 321602 comment 10. I've put up a feature patch that should resolve this issue with the first SR1 of Helios.
Comment 8 Carsten Pfeiffer CLA 2010-10-06 11:30:13 EDT 
Cool, thanks a bunch :-)