Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325454 - Refactor TextLocation and EObjectAtOffsetHelper
Summary: Refactor TextLocation and EObjectAtOffsetHelper
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 2.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: M2   Edit
Assignee: Jan Koehnlein CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 08:45 EDT by Jan Koehnlein CLA
Modified: 2017-09-19 15:50 EDT (History)
1 user (show)

See Also:
jan: indigo+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Koehnlein CLA 2010-09-16 08:45:28 EDT 
TextLocation
- it should be immutable
- it should rather be called TextRegion
- there should be a NULL literal to start a chain of merge operations

EObjectAtOffsetHelper
- should not be static
- rethink it's methods, as they are currently serving multiple purposes at once
- merge with ILocationInFileProvider
Comment 1 Jan Koehnlein CLA 2010-09-17 04:39:51 EDT 
Fixed in master, commit 840435da4d784c2735193dde3b9292801f9e09bd

I havent't merged EObjectAtOffsetHelper with LocationInFileProvider, as the latter already contains a lot of code.
Comment 2 Karsten Thoms CLA 2017-09-19 15:50:07 EDT 
Closing bug which were set to RESOLVED before Eclipse Neon.0.