Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325425 - natureEnablements is unnecessary synchronized (Nature Manager)
Summary: natureEnablements is unnecessary synchronized (Nature Manager)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-16 05:42 EDT by Malgorzata Janczarska CLA
Modified: 2010-09-20 04:05 EDT (History)
1 user (show)

See Also:
Szymon.Brandys: review+

Attachments
Proposed patch (915 bytes, patch)
2010-09-16 05:49 EDT, Malgorzata Janczarska CLA 		Szymon.Brandys: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2010-09-16 05:42:11 EDT 
Build identifier: I20100912-2000

After fixing the bug 307587 all methods using natureEnablements map have been synchronized and the map was left redundantly synchronized. This leads to creating redundant locks each time natureEnablements is referenced.
Comment 1 Malgorzata Janczarska CLA 2010-09-16 05:49:47 EDT 
Created attachment 179009 [details]
Proposed patch
Comment 2 Szymon Brandys CLA 2010-09-16 06:03:01 EDT 
Thanks Gosia.
Comment 3 Szymon Brandys CLA 2010-09-20 03:58:46 EDT 
Checked in to HEAD.