Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325390 - No menu contribution is showing up for the PIIclipse bundles
Summary: No menu contribution is showing up for the PIIclipse bundles
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.1 M3   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 16:16 EDT by Olivier Thomann CLA
Modified: 2011-05-13 14:47 EDT (History)
2 users (show)

See Also:

Attachments
plugin.xml that is containing the menu contribution (11.15 KB, text/plain)
2010-09-15 16:20 EDT, Olivier Thomann CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-09-15 16:16:35 EDT 
Once these bundles are installed, there is no menu contribution that shows up.
Preference page, builder, markers work fine though.
Comment 1 Olivier Thomann CLA 2010-09-15 16:20:44 EDT 
Created attachment 178979 [details]
plugin.xml that is containing the menu contribution
Comment 2 Remy Suen CLA 2010-09-16 13:52:20 EDT 
In PopupMenuExtender's addMenuContributions(IMenuManager) method, we create a MenuManager which ends up not having any items in it (as we expect them to be coming from an MMC) so the submenu itself is never displayed.
Comment 3 Remy Suen CLA 2010-09-16 14:34:55 EDT 
The code that is there was written to fix bug 318855. If I cut out the code then bug 318855 will come back (obviously) but the menu contribution will show up correctly.

I forgot to mention in the previous comment that there are currently two issues preventing this popup contribution from appearing. The first is that the commands are nested within a <menu> element, which explains comment 2. The second problem is that the 'activeMenuSelection' and 'activeMenuEditorInput' variables are not available in the context [for evaluation].
Comment 4 Paul Webster CLA 2010-09-16 14:49:30 EDT 
I think it's too risky to fix tonight, we'll fix it next week (unless something brilliant occurs to you :-)

PW
Comment 5 Olivier Thomann CLA 2010-09-16 15:50:56 EDT 
Anything that can be done in the bundle's plugin.xml to get the menu?
Comment 6 Remy Suen CLA 2010-09-16 15:58:27 EDT 
(In reply to comment #5)
> Anything that can be done in the bundle's plugin.xml to get the menu?

At the moment, I think you'll have to turn them into object contributions which will require some code changes.
Comment 7 Paul Webster CLA 2010-09-16 16:14:44 EDT 
We need to fix this (your plugin.xml is correct), I just suspect it needs to be next week.

A workaround that may (or may not) work for you would be to use CTRL+3 <the initials of the command you want>

I often use CTRL+3 cbi (Copy Build Id)

PW
Comment 8 Olivier Thomann CLA 2010-10-04 11:50:59 EDT 
(In reply to comment #7)
> A workaround that may (or may not) work for you would be to use CTRL+3 <the
> initials of the command you want>
Using Ctrl + 3 works, but I consider this only as a temporary workaround.
Comment 9 Steffen Pingel CLA 2010-10-18 18:52:08 EDT 
Is this the same as bug 324494?
Comment 10 Paul Webster CLA 2010-10-19 07:06:07 EDT 
(In reply to comment #9)
> Is this the same as bug 324494?

Yes, in that they're both tied to bug 325392

What I'm working on there should fix this and bug 324494

PW
Comment 11 Paul Webster CLA 2010-10-25 13:55:15 EDT 
As a workaround I've added activeMenuSelection and the other variables to the application context.

I'll release it for tonight's build.

PW
Comment 12 Paul Webster CLA 2011-05-13 14:47:18 EDT 
I believe this is fixed now.

PW