Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325367 - [Net] Unnecessary double check bypass settings in AbstractProxyProvider.select(URI)
Summary: [Net] Unnecessary double check bypass settings in AbstractProxyProvider.selec...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-15 11:25 EDT by Wojciech Galanciak CLA
Modified: 2010-10-07 07:31 EDT (History)
0 users

See Also:
Szymon.Brandys: review+


Attachments
initial patch (6.35 KB, patch)
2010-09-16 10:47 EDT, Wojciech Galanciak CLA
Szymon.Brandys: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Galanciak CLA 2010-09-15 11:25:50 EDT
Bug created for a problem mentioned in bug 323378 comment 3.

For Windows this code is unnecessary cause bypasses are checked again in ProxyBypass.bypassProxyFor(URI). With fix for bug 323378 it will support *.eclipse.org and eclipse.* patterns.

For Linux (without Gnome) this is the only place where bypasses are checked. In this case there is no support for bypasses with * on Linux (no Gnome).

For Gnome I will check native code if there is any method which checks bypasses. If not, the situation will be the same as in Linux without Gnome.

First possible solution is to add support for bypass patterns in AbstractProxyProvider. In this case bypass checking should be removed from WindowsProxyProvider.

The second one is to remove it from AbstractProxyProvider at all and move responsibility for that to UnixProxyProvider (the same approach as in Windows).
Comment 1 Wojciech Galanciak CLA 2010-09-16 10:47:03 EDT
Created attachment 179037 [details]
initial patch

This patch moves responsibility for checking bypasses from AbstractProxyProvider to WindowsProxyProvider and UnixProxyProvider. It passes unit tests for Windows. To be sure that the patch is fully correct I need to check it also on Linux machine.
Comment 2 Szymon Brandys CLA 2010-10-07 07:31:06 EDT
Looks good. Please verify on Linux though.