Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325248 - [historyView] CommitFileDiffViewer does not adapt on filter change
Summary: [historyView] CommitFileDiffViewer does not adapt on filter change
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mathias Kinzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 09:28 EDT by Stefan Lay CLA
Modified: 2010-10-29 07:33 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2010-09-14 09:28:39 EDT 
The CommitFileDiffViewer (displaying the list of files contained in a commit, filtered by the selected filter) does not adapt the list of files when the filter selection changes. It only adapts when another commit is selected.

The reason is that the method inputChanged only does anything if the SWTCommit changes which serves as the input. Setting a new setTreeWalk does not trigger a refresh.
Comment 1 Mathias Kinzler CLA 2010-10-27 08:03:26 EDT 
Code review at http://egit.eclipse.org/r/#change,1807
Comment 2 Matthias Sohn CLA 2010-10-29 07:33:51 EDT 
merged as 081b6eb8c37781c8a47c7ec58f29bb8db55a549e