Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325159 - [type hierarchy] Type hierarchy on package and type should gray out some types
Summary: [type hierarchy] Type hierarchy on package and type should gray out some types
Status: RESOLVED INVALID
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P2 minor (vote)
Target Milestone: ---   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 325336
Blocks:
  Show dependency tree
 
Reported: 2010-09-13 16:02 EDT by Markus Keller CLA
Modified: 2010-09-16 04:51 EDT (History)
2 users (show)

See Also:

Attachments
patch (2.23 KB, patch)
2010-09-15 08:50 EDT, Raksha Vasisht CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-09-13 16:02:54 EDT 
Follow-up to bug 21417

Type hierarchy on package and type should gray out some types. The rendering should be a merge of the hierarchy on m and the hierarchy on the type (types should be colored if they could be both).

package m;
public class A { }
package m;
public class B extends Exception {}

package m2;
public interface IThing { }
package m2;
public class Thing implements IThing { }


- open type hierarchy on m and IThing
=> Object, Throwable, and Exception should be gray

- open type hierarchy on m and Thing
=> Throwable and Exception should be gray
Comment 1 Dani Megert CLA 2010-09-14 02:20:45 EDT 
This should be fixed for M2 since this is a N&N item.
Comment 2 Raksha Vasisht CLA 2010-09-15 08:50:47 EDT 
Created attachment 178925 [details]
patch

The problem was in isInDifferentHierarchyScope(..) which completely has different meaning now with support for multi-selection. Now only the types which belong to the hierarchies of all input elements should be colored, rest should be grayed. Earlier fix colored types which were either input or was contained in one of the java elements which was not fully correct. Markus, could you pls review?
Comment 3 Raksha Vasisht CLA 2010-09-15 18:09:20 EDT 
Works for now with patch for bug 325336 comment #14. Will revisit if Open Type Hierarchy is enabled for combination of types + other selections.
Comment 4 Dani Megert CLA 2010-09-16 04:51:10 EDT 
This bug got invalidated by the fix for bug 325336.