Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325150 - edc - ARM - disassembly - fix for "duplicate line" and "missing line" bugs
Summary: edc - ARM - disassembly - fix for "duplicate line" and "missing line" bugs
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 14:12 EDT by Kirk Beitz CLA
Modified: 2010-10-06 22:45 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirk Beitz CLA 2010-09-13 14:12:00 EDT 
ARMDisassembly.java was duplicating effort by figuring out the ARM-or-Thumb mode in both the getMixedInstructions() and getInstructions() functions … and in certain circumstances, this was resulting in either duplicate assembly entries or else missing lines in the code.

the code in ARMDisassembly.java has been re-factored so that if getMixedInstructions() performs the getModeAndRange() prior to calling getInstructions(), it passes the range, and getInstructions() now uses the pre-calculated range if non-null.  (if null, it calculates the range as it had before, so that external callers get the same behavior.)

(this bugzilla entry is a placeholder for changes to be merged that have
already been committed and tested in the nokia database.  presumably such a
merge will also go on the CDT_7_0 branch for 7.0.2 after cdt 7.0.1 is
released.)
Comment 1 Kirk Beitz CLA 2010-10-06 22:45:32 EDT 
resolved with 2010.oct.04 edc merge commits by ken.ryall@nokia.com