Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325141 - Truncated button in Import/Export a service configuration
Summary: Truncated button in Import/Export a service configuration
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Service Model (show other bugs)
Version: 4.0.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.0.3   Edit
Assignee: Vivian Kong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-13 13:22 EDT by Vivian Kong CLA
Modified: 2010-09-13 13:23 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vivian Kong CLA 2010-09-13 13:22:03 EDT
The Select/Deselect All button text were truncated for translation that is longer than the preset button width.  The preset button width should be removed so the buttons can be resized for translation.

Here's a 2-lines patch


### Eclipse Workspace Patch 1.0
#P org.eclipse.ptp.services.ui
Index: src/org/eclipse/ptp/services/ui/widgets/ServiceConfigurationSelectionWidget.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.ptp/core/org.eclipse.ptp.services.ui/src/org/eclipse/ptp/services/ui/widgets/ServiceConfigurationSelectionWidget.java,v
retrieving revision 1.13
diff -u -r1.13 ServiceConfigurationSelectionWidget.java
--- src/org/eclipse/ptp/services/ui/widgets/ServiceConfigurationSelectionWidget.java	29 Oct 2009 15:50:46 -0000	1.13
+++ src/org/eclipse/ptp/services/ui/widgets/ServiceConfigurationSelectionWidget.java	13 Sep 2010 17:21:38 -0000
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2009 IBM Corporation and others.
+ * Copyright (c) 2009, 2010 IBM Corporation and others.
  * All rights reserved. This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v1.0
  * which accompanies this distribution, and is available at
@@ -285,7 +285,6 @@
 			
 			fSelectAllButton = new Button(buttonsComp, SWT.PUSH);
 			data = new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1);
-			data.widthHint = BUTTON_WIDTH;
 			fSelectAllButton.setLayoutData(data);
 			fSelectAllButton.setText(Messages.ServiceConfigurationSelectionWidget_5);
 			fSelectAllButton.setEnabled(false);
@@ -297,7 +296,6 @@
 		
 			fDeselectAllButton = new Button(buttonsComp, SWT.PUSH);
 			data = new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1);
-			data.widthHint = BUTTON_WIDTH;
 			fDeselectAllButton.setLayoutData(data);
 			fDeselectAllButton.setText(Messages.ServiceConfigurationSelectionWidget_6);
 			fDeselectAllButton.setEnabled(false);
Comment 1 Vivian Kong CLA 2010-09-13 13:23:28 EDT
Fixed in ptp_4_0 and HEAD.