Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 325016 - [TMF] Implementation of Time Chart view
Summary: [TMF] Implementation of Time Chart view
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: LinuxTools (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Patrick Tasse CLA
QA Contact: Francois Chouinard CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 301610
  Show dependency tree
 
Reported: 2010-09-10 17:28 EDT by Patrick Tasse CLA
Modified: 2022-01-13 14:53 EST (History)
1 user (show)

See Also:


Attachments
Proposed patch in org.eclipse.linuxtools.tmf.ui package (62.94 KB, patch)
2010-09-10 17:30 EDT, Patrick Tasse CLA
no flags Details | Diff
Corrected patch for TimeChartAnalysisEntry.java (9.36 KB, patch)
2010-11-30 11:27 EST, Patrick Tasse CLA
no flags Details | Diff
Updated patch for TmfTimeStatesCtrl.java (22.31 KB, patch)
2010-12-02 14:54 EST, Patrick Tasse CLA
no flags Details | Diff
Proposed patch in org.eclipse.linuxtools.tmf.ui package (92.08 KB, patch)
2011-02-23 18:28 EST, Patrick Tasse CLA
jjohnstn: iplog+
Details | Diff
icons zip file for org.eclipse.linuxtools.tmf.ui package (391 bytes, application/zip)
2011-02-23 18:36 EST, Patrick Tasse CLA
jjohnstn: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tasse CLA 2010-09-10 17:28:50 EDT
Build Identifier: 

Submitting a patch to add a generic Time Chart view to TMF.

Also includes some Time Analysis Viewer widget improvements and bug fixes.

Detailed changes:

* Time Chart View:

- The view contains a Time Analysis Viewer widget with one entry (row) per opened trace editor.
- When the view is opened, if there are any opened trace editors, the view will update itself with all currently indexed events from those traces.
- When a trace editor is opened, a corresponding entry is added to the time chart view, with no events. The entry automatically gets updated with new events as the trace is indexed.
- When a trace editor is closed, the corresponding entry is removed.
- Clicking on an entry in the Time Chart view brings the corresponding trace editor to the front, and synchronizes on the time that was clicked.
- Giving focus to a trace editor makes the corresponding entry highlighted in the Time Chart view.
- Clicking on an event in a trace editor makes its timestamp the selected time in the Time Chart view.
- The data model used by the Time Chart view initially contains roughly no more events than the number of viewable pixels in the display. Each model event may represent one or many trace events. When the user zooms in the time chart, the model events are itemized on-the-fly up to the current viewable detail level, creating a sub-tree of detailed events only as necessary.
- To achieve this the data model provides a thread-safe iterator that iterates over the whole sub-tree of events only down to the currently viewable detail level, even if more detailed events exist. The iterator also handles events being added by another thread (e.g. by ongoing trace indexing) to any position in the model during the iteration.

* Time Analysis Viewer:

- The interface of the time analysis entry is modified to allow getting an iterator of events instead of a vector.
- The widget now uses the iterator to get model events when drawing itself.
- Fixed division by zero exception when time interval is very small.
- Fixed rounding errors during mouse zoom.
- Fixed redraw logic when selecting an item.
- Fixed drawing of backgrounds.
- Fixed event item width at boundaries, and added an interface for the user to specify a minimum event item width.
- Fixed object persistence of mouse scroll filter listener.
- Fixed handling of multiple mouse button drag.
- Fixed problem in finding of trace item with duplicate trace id.
- Removed displaying of empty information in event tooltip.
- Fixed non-generic tooltip labels referring to threads.
- Fixed resetting of widget settings when model updated with new items.


Reproducible: Always
Comment 1 Patrick Tasse CLA 2010-09-10 17:30:25 EDT
Created attachment 178665 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2010-11-30 11:27:43 EST
Created attachment 184142 [details]
Corrected patch for TimeChartAnalysisEntry.java

Corrected patch for TimeChartAnalysisEntry.java

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 3 Patrick Tasse CLA 2010-12-02 14:54:43 EST
Created attachment 184392 [details]
Updated patch for TmfTimeStatesCtrl.java

Submitting an updated patch for TmfTimeStatesCtrl.java because this file has been reformatted (tabs to spaces) in the repository.

Additional fixes in the patch:

- Fixed filling space not erasing the full state area
- Removed a hack correcting this by drawing background-colored lines over the missed area

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 4 Patrick Tasse CLA 2011-02-23 18:28:55 EST
Created attachment 189664 [details]
Proposed patch in org.eclipse.linuxtools.tmf.ui package

Updated patch for new baseline.

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 5 Patrick Tasse CLA 2011-02-23 18:36:23 EST
Created attachment 189665 [details]
icons zip file for org.eclipse.linuxtools.tmf.ui package
Comment 6 Patrick Tasse CLA 2013-05-22 16:01:32 EDT
commit 4090619872fd8f26bd3ddc9d34fff513a0127afd

Released in 0.8.0.