Community
Participate
Working Groups
Build Identifier: Submitting a patch to add a generic Time Chart view to TMF. Also includes some Time Analysis Viewer widget improvements and bug fixes. Detailed changes: * Time Chart View: - The view contains a Time Analysis Viewer widget with one entry (row) per opened trace editor. - When the view is opened, if there are any opened trace editors, the view will update itself with all currently indexed events from those traces. - When a trace editor is opened, a corresponding entry is added to the time chart view, with no events. The entry automatically gets updated with new events as the trace is indexed. - When a trace editor is closed, the corresponding entry is removed. - Clicking on an entry in the Time Chart view brings the corresponding trace editor to the front, and synchronizes on the time that was clicked. - Giving focus to a trace editor makes the corresponding entry highlighted in the Time Chart view. - Clicking on an event in a trace editor makes its timestamp the selected time in the Time Chart view. - The data model used by the Time Chart view initially contains roughly no more events than the number of viewable pixels in the display. Each model event may represent one or many trace events. When the user zooms in the time chart, the model events are itemized on-the-fly up to the current viewable detail level, creating a sub-tree of detailed events only as necessary. - To achieve this the data model provides a thread-safe iterator that iterates over the whole sub-tree of events only down to the currently viewable detail level, even if more detailed events exist. The iterator also handles events being added by another thread (e.g. by ongoing trace indexing) to any position in the model during the iteration. * Time Analysis Viewer: - The interface of the time analysis entry is modified to allow getting an iterator of events instead of a vector. - The widget now uses the iterator to get model events when drawing itself. - Fixed division by zero exception when time interval is very small. - Fixed rounding errors during mouse zoom. - Fixed redraw logic when selecting an item. - Fixed drawing of backgrounds. - Fixed event item width at boundaries, and added an interface for the user to specify a minimum event item width. - Fixed object persistence of mouse scroll filter listener. - Fixed handling of multiple mouse button drag. - Fixed problem in finding of trace item with duplicate trace id. - Removed displaying of empty information in event tooltip. - Fixed non-generic tooltip labels referring to threads. - Fixed resetting of widget settings when model updated with new items. Reproducible: Always
Created attachment 178665 [details] Proposed patch in org.eclipse.linuxtools.tmf.ui package Legal Message: I, Patrick Tasse, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Created attachment 184142 [details] Corrected patch for TimeChartAnalysisEntry.java Corrected patch for TimeChartAnalysisEntry.java Legal Message: I, Patrick Tasse, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Created attachment 184392 [details] Updated patch for TmfTimeStatesCtrl.java Submitting an updated patch for TmfTimeStatesCtrl.java because this file has been reformatted (tabs to spaces) in the repository. Additional fixes in the patch: - Fixed filling space not erasing the full state area - Removed a hack correcting this by drawing background-colored lines over the missed area Legal Message: I, Patrick Tasse, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Created attachment 189664 [details] Proposed patch in org.eclipse.linuxtools.tmf.ui package Updated patch for new baseline. Legal Message: I, Patrick Tasse, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
Created attachment 189665 [details] icons zip file for org.eclipse.linuxtools.tmf.ui package
commit 4090619872fd8f26bd3ddc9d34fff513a0127afd Released in 0.8.0.