Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324975 - [Diagram] In place edit of aEnd and zEnd names causes an IllegalArgumentException
Summary: [Diagram] In place edit of aEnd and zEnd names causes an IllegalArgumentExcep...
Status: RESOLVED FIXED
Alias: None
Product: Tigerstripe
Classification: Technology
Component: Diagrams (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 0.5M0   Edit
Assignee: Daniel Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 10:41 EDT by Navid Mehregani CLA
Modified: 2010-09-21 19:09 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Navid Mehregani CLA 2010-09-10 10:41:31 EDT
Build Identifier: 

In place editing of aEnd and zEnd names causes the following exception in Error log view:

java.lang.IllegalArgumentException: Argument not valid
at org.eclipse.swt.SWT.error(SWT.java:3865)
at org.eclipse.swt.SWT.error(SWT.java:3799)
at org.eclipse.swt.SWT.error(SWT.java:3770)
at org.eclipse.swt.graphics.GC.setFont(GC.java:3320)
at org.eclipse.draw2d.FigureUtilities.setFont(FigureUtilities.java:363)
at org.eclipse.draw2d.FigureUtilities.getFontMetrics(FigureUtilities.java:59)
at org.eclipse.tigerstripe.workbench.ui.visualeditor.diagram.edit.parts.TigerstripeEditPartFactory$TextCellEditorLocator.relocate(TigerstripeEditPartFactory.java:284)
at org.eclipse.gef.tools.DirectEditManager.placeCellEditor(DirectEditManager.java:314)
at org.eclipse.gef.tools.DirectEditManager.access$1(DirectEditManager.java:313)
at org.eclipse.gef.tools.DirectEditManager$1.ancestorMoved(DirectEditManager.java:244)
at org.eclipse.draw2d.AncestorHelper.fireAncestorMoved(AncestorHelper.java:104)
at org.eclipse.draw2d.AncestorHelper.figureMoved(AncestorHelper.java:91)
at org.eclipse.draw2d.Figure.fireFigureMoved(Figure.java:493)
at org.eclipse.draw2d.Figure.setBounds(Figure.java:1519)
at org.eclipse.draw2d.Figure.setSize(Figure.java:1791)
at org.eclipse.draw2d.Figure.setSize(Figure.java:1779)
at org.eclipse.gmf.runtime.draw2d.ui.internal.figures.DelegatingLayout.layout(DelegatingLayout.java:43)
at org.eclipse.draw2d.Figure.layout(Figure.java:1093)
at org.eclipse.draw2d.PolylineConnection.layout(PolylineConnection.java:179)
at org.eclipse.draw2d.Figure.validate(Figure.java:1894)
at org.eclipse.draw2d.Figure.validate(Figure.java:1896)
at org.eclipse.draw2d.Figure.validate(Figure.java:1896)
at org.eclipse.draw2d.Figure.validate(Figure.java:1896)
at org.eclipse.draw2d.Figure.validate(Figure.java:1896)
at org.eclipse.draw2d.FreeformViewport$FreeformViewportLayout.calculatePreferredSize(FreeformViewport.java:25)
at org.eclipse.draw2d.AbstractLayout.getPreferredSize(AbstractLayout.java:110)
at org.eclipse.draw2d.AbstractHintLayout.getPreferredSize(AbstractHintLayout.java:90)
at org.eclipse.draw2d.Figure.getPreferredSize(Figure.java:807)
at org.eclipse.draw2d.ScrollPaneSolver.solve(ScrollPaneSolver.java:82)
at org.eclipse.draw2d.FigureCanvas.layoutViewport(FigureCanvas.java:325)
at org.eclipse.draw2d.FigureCanvas.access$4(FigureCanvas.java:323)
at org.eclipse.draw2d.FigureCanvas$3.notifyValidating(FigureCanvas.java:292)
at org.eclipse.draw2d.UpdateManager.fireValidating(UpdateManager.java:143)
at org.eclipse.draw2d.DeferredUpdateManager.performValidation(DeferredUpdateManager.java:214)
at org.eclipse.gmf.runtime.diagram.ui.parts.DiagramGraphicalViewer$ToggleUpdateManager.performValidation(DiagramGraphicalViewer.java:124)
at org.eclipse.draw2d.DeferredUpdateManager.paint(DeferredUpdateManager.java:164)
at org.eclipse.draw2d.LightweightSystem.paint(LightweightSystem.java:203)
at org.eclipse.draw2d.LightweightSystem$2.handleEvent(LightweightSystem.java:110)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3543)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1250)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1273)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Control.drawWidget(Control.java:1079)
at org.eclipse.swt.widgets.Canvas.drawWidget(Canvas.java:158)
at org.eclipse.swt.widgets.Widget.drawRect(Widget.java:589)
at org.eclipse.swt.widgets.Canvas.drawRect(Canvas.java:153)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4635)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Display.applicationNextEventMatchingMask(Display.java:4188)
at org.eclipse.swt.widgets.Display.applicationProc(Display.java:4386)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
at org.eclipse.swt.internal.cocoa.NSApplication.nextEventMatchingMask(NSApplication.java:75)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3094)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)
at org.eclipse.equinox.launcher.Main.main(Main.java:1287)


Reproducible: Always

Steps to Reproduce:
1. Create a new class diagram
2. Create two Entities
3. Create an association between entities
4. Select name of aEnd
5. Type in a new name and press enter.  Notice that the name is grayed out and an IllegalArgumentException is thrown in Error log view.
Comment 1 Daniel Johnson CLA 2010-09-16 18:03:12 EDT
Hey Navid, I am not able to reproduce this. Editing the name seems to work fine for me, and it does not grey out like you mention. No errors are showing up in errorLog. Tried both aEnd and zEnd.
Comment 2 Navid Mehregani CLA 2010-09-16 18:05:17 EDT
(In reply to comment #1)
> Hey Navid, I am not able to reproduce this. Editing the name seems to work fine
> for me, and it does not grey out like you mention. No errors are showing up in
> errorLog. Tried both aEnd and zEnd.

Hmm, that's strange, are you running against the latest changes?
Comment 3 Daniel Johnson CLA 2010-09-16 18:32:09 EDT
(In reply to comment #2)
> Hmm, that's strange, are you running against the latest changes?

As far as I know yes, I updated yesterday. Based on the error log it seems as though maybe you were using an unsupported font? Did you mess with the font settings at all? I tried changing the font settings on mine but it didn't seem to change anything but the color. Even then I was still not able to reproduce the error.
Comment 4 Navid Mehregani CLA 2010-09-21 19:09:42 EDT
Alright, after running a fresh update and erasing my workspace, I was no longer able to reproduce this issue.  

I'll mark this as fixed and will reopen it if I ever come across it again.