Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324943 - [historyView] Change http://egit.eclipse.org/r/#change,1425 broke refresh
Summary: [historyView] Change http://egit.eclipse.org/r/#change,1425 broke refresh
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 06:32 EDT by Mathias Kinzler CLA
Modified: 2010-09-13 09:51 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-09-10 06:32:26 EDT 
Change http://egit.eclipse.org/r/#change,1425 (Change-Id: Ib6336db04ee8fae98588671a880a1c08f194c84d) has broken the "Refresh" action of the history view. An error is written to the log, and refresh has no effect.
A quick look at the code indicates that setting currentHeadId to null in the reset() method of the GitHistoryPage may solve the issue.
Comment 1 Stefan Lay CLA 2010-09-13 07:23:54 EDT 
Review at http://egit.eclipse.org/r/#change,1588
Comment 2 Matthias Sohn CLA 2010-09-13 09:51:47 EDT 
merged as a35fb8c652acbfd41292d1c97b5998dd26a0dfce