Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324939 - PlotWalk.getTags(): sorting is not stable
Summary: PlotWalk.getTags(): sorting is not stable
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-10 05:54 EDT by Mathias Kinzler CLA
Modified: 2010-12-03 16:23 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-09-10 05:54:59 EDT
The underlying issue is that the PlotRefComparator does only look at the commit time. If there are symbolic references, however, the commit time will not differ. Probably the comparator must take additional information into account when the times are the same. Ideally, the sorting should also be by type (tags, heads, remote). Alternatively, the AbstractPlotReneder could re-sort the array before drawing the labels.
The symptom in the EGit UI is that if you hit refresh on the History View, sometimes the sequence of the branch and tag labels (and the HEAD label) changes. Also, tags, branches, and remote branches are wildly mixed.
Comment 1 Shawn Pearce CLA 2010-12-03 16:23:59 EST
Fixed by change Ifc3863461654df7f34fdecbd2abe1f4b5d2ffb8e

http://egit.eclipse.org/r/2032