Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324911 - HTML Proposal Computer is too lax with element proposals
Summary: HTML Proposal Computer is too lax with element proposals
Status: CLOSED WONTFIX
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: WI 56705
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 18:23 EDT by Nick Sandonato CLA
Modified: 2010-09-13 11:48 EDT (History)
1 user (show)

See Also:
thatnitind: review+


Attachments
patch (1.73 KB, patch)
2010-09-09 18:26 EDT, Nick Sandonato CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-09-09 18:23:11 EDT
The HTML Proposal Computer is too lax with element proposals. By allowing any
subclass of CMElementDeclarationImpl to be valid, we see several duplicate
proposals contributed in particular because of the use of model query
extensions.
Comment 1 Nick Sandonato CLA 2010-09-09 18:26:42 EDT
Created attachment 178574 [details]
patch
Comment 2 Nitin Dahyabhai CLA 2010-09-09 19:13:00 EDT
Patch is a partial revert of the changes in HTMLTagsCompletionProposalComputer from 1.4.2.1 to 1.4.2.2.  Approved.
Comment 3 Nick Sandonato CLA 2010-09-13 11:48:53 EDT
This change is actually unnecessary. Closing this one out.