Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324888 - Need to subclass CSourceHover
Summary: Need to subclass CSourceHover
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 7.0.1   Edit
Assignee: Vivian Kong CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-09 14:45 EDT by Violaine Batthish CLA
Modified: 2010-09-14 11:23 EDT (History)
4 users (show)

See Also:
aleherb+eclipse: review+

Attachments
patch for protected methods (1.61 KB, patch)
2010-09-09 14:45 EDT, Violaine Batthish CLA 		vivkong: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Violaine Batthish CLA 2010-09-09 14:45:20 EDT 
Created attachment 178545 [details]
patch for protected methods

I need to subclass CSourceHover, and I need for the following methods to be made protected so that I can add my code:
SingletonRule
ComputeSourceRunnable
searchInIndex

I have attached a patch
Comment 1 Chris Recoskie CLA 2010-09-09 14:57:29 EDT 
Other than the usual caveats about the dangers of subclassing internals, I don't really see a problem with making these things protected instead of private.  Toni, do you have any thoughts?
Comment 2 Anton Leherbauer CLA 2010-09-13 04:44:31 EDT 
That's fine with me.
Comment 3 Vivian Kong CLA 2010-09-14 10:33:19 EDT 
Applied to HEAD and cdt_7_0.  Thanks.