Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 324810 - [block selection] specify a win7 font value for org.eclipse.ui.workbench.texteditor.blockSelectionModeFont
Summary: [block selection] specify a win7 font value for org.eclipse.ui.workbench.text...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal with 1 vote (vote)
Target Milestone: 4.6 M7   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard: fix candidate
Keywords:
: 346374 (view as bug list)
Depends on: 324882
Blocks:
  Show dependency tree
 
Reported: 2010-09-08 20:07 EDT by Susan McCourt CLA
Modified: 2016-04-22 08:52 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2010-09-08 20:07:29 EDT 
per bug 320616, we now have a win7 jface fonts file.
We specify "Consolas" as the default jface text font (see [1]).
The font definition in the themes extension point in org.eclipse.ui.workbench.texteditor should specify this same font when os="windows7"

[1] (from MS Consolas font pack)
Consolas is intended for use in programming environments and other circumstances where a monospaced font is specified. All characters have the same width, like old typewriters, making it a good choice for personal and business correspondence. Optimizing the font specifically for ClearType allowed a design with proportions closer to normal text than traditional monospaced fonts like Courier. This allows for more comfortable reading of extended text on-screen.
Comment 1 Markus Keller CLA 2010-09-09 13:58:51 EDT 
We can't fix this right now, see bug 324882. After that, the fix is to add:

         <fontValue
               os="win32"
               osName="Windows 7"
               value="Consolas-regular-10">
         </fontValue>
Comment 2 Markus Keller CLA 2015-12-10 10:37:24 EST 
*** Bug 346374 has been marked as a duplicate of this bug. ***
Comment 3 Markus Keller CLA 2015-12-10 11:26:01 EST 
Since all pre-Win7 OSes are out of support, we could safely change the default for win32 to Consolas-regular-10 now.

But the right solution is to remove the platform-specific font definitions and use an AbstractPreferenceInitializer to set the default value for the blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.
Comment 4 Markus Keller CLA 2016-04-21 13:52:11 EDT 
(In reply to Markus Keller from comment #3)
> Since all pre-Win7 OSes are out of support, we could safely change the
> default for win32 to Consolas-regular-10 now.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=579ff36747d2c917fc9edc055a8ce753284c2f4c

> But the right solution is to remove the platform-specific font definitions
> and use an AbstractPreferenceInitializer to set the default value for the
> blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.

Keeping the bug open for that.
Comment 5 Dani Megert CLA 2016-04-22 08:52:12 EDT 
(In reply to Markus Keller from comment #4)
> > But the right solution is to remove the platform-specific font definitions
> > and use an AbstractPreferenceInitializer to set the default value for the
> > blockSelectionModeFont to the default value of JFaceResources.TEXT_FONT.
> 
> Keeping the bug open for that.

Filed bug 492247 for that.